Skip to content

feat: Implementing online_read for MilvusOnlineStore #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Feb 1, 2025
Merged

feat: Implementing online_read for MilvusOnlineStore #4996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f448b2c
feat: Implementing online_read for MilvusOnlineStore
franciscojavierarceo Jan 31, 2025
7aa8e77
updated tests and implementation to handle for missing entities
franciscojavierarceo Jan 31, 2025
28b05c5
ignoring local milvus test
franciscojavierarceo Feb 1, 2025
edba589
adding milvus md and incorporating feedback from Lokesh
franciscojavierarceo Feb 1, 2025
8c605c1
including Milvus in summary page
franciscojavierarceo Feb 1, 2025
cb71592
linter
franciscojavierarceo Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
including Milvus in summary page 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Feb 1, 2025
commit 8c605c18031fea60e9b95103adf4ba1ed93302c6
1 change: 1 addition & 0 deletions docs/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
* [Hazelcast](reference/online-stores/hazelcast.md)
* [ScyllaDB](reference/online-stores/scylladb.md)
* [SingleStore](reference/online-stores/singlestore.md)
* [Milvus](reference/online-stores/milvus.md)
* [Registries](reference/registries/README.md)
* [Local](reference/registries/local.md)
* [S3](reference/registries/s3.md)
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/milvus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The [Milvus](https://milvus.io/) online store provides support for materializing
* The data model used to store feature values in Milvus is described in more detail [here](../../specs/online\_store\_format.md).

## Getting started
In order to use this online store, you'll need to install the redis extra (along with the dependency needed for the offline store of choice). E.g.
In order to use this online store, you'll need to install the Milvus extra (along with the dependency needed for the offline store of choice). E.g.

`pip install 'feast[milvus]'`

Expand Down Expand Up @@ -35,7 +35,7 @@ online_store:
{% endcode %}


The full set of configuration options is available in [RedisOnlineStoreConfig](https://rtd.feast.dev/en/latest/#feast.infra.online_stores.redis.RedisOnlineStoreConfig).
The full set of configuration options is available in [MilvusOnlineStoreConfig](https://rtd.feast.dev/en/latest/#feast.infra.online_stores.milvus.MilvusOnlineStoreConfig).

## Functionality Matrix

Expand Down