Skip to content

chore: CR image no longer needed for e2e (v0.43-branch) #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 1 commit into from
Jan 21, 2025
Merged

chore: CR image no longer needed for e2e (v0.43-branch) #4943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CR image no longer needed for e2e 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
@tchughesiv
tchughesiv committed Jan 21, 2025
commit ab4a9c7692090a223733c4d23ea85c3651bef230
2 changes: 1 addition & 1 deletion infra/feast-operator/test/e2e/test_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func checkIfKubernetesServiceExists(namespace, serviceName string) error {

func isFeatureStoreHavingRemoteRegistry(namespace, featureStoreName string) (bool, error) {
cmd := exec.Command("kubectl", "get", "featurestore", featureStoreName, "-n", namespace,
"-o=jsonpath='{.spec.services.registry}'")
"-o=jsonpath='{.status.applied.services.registry}'")

// Capture the output
output, err := cmd.Output()
Expand Down
9 changes: 2 additions & 7 deletions ...east-operator/test/testdata/feast_integration_test_crs/v1alpha1_default_featurestore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,5 @@ metadata:
spec:
feastProject: my_project
services:
onlineStore:
image: 'localhost/feastdev/feature-server:dev'
offlineStore:
image: 'localhost/feastdev/feature-server:dev'
registry:
local:
image: 'localhost/feastdev/feature-server:dev'
onlineStore: {}
offlineStore: {}
6 changes: 2 additions & 4 deletions ...rator/test/testdata/feast_integration_test_crs/v1alpha1_remote_registry_featurestore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ metadata:
spec:
feastProject: my_project
services:
onlineStore:
image: 'localhost/feastdev/feature-server:dev'
offlineStore:
image: 'localhost/feastdev/feature-server:dev'
onlineStore: {}
offlineStore: {}
registry:
remote:
feastRef:
Expand Down