Skip to content

馃嵀 ADD - Route definition #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Jan 10, 2025
Merged

馃嵀 ADD - Route definition #4914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/charts/feast-feature-server/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: feast-feature-server
description: Feast Feature Server in Go or Python
type: application
version: 0.42.0
version: 0.42.1
keywords:
- machine learning
- big data
Expand Down
3 changes: 2 additions & 1 deletion infra/charts/feast-feature-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,5 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
| service.port | int | `80` | |
| service.type | string | `"ClusterIP"` | |
| serviceAccount.name | string | `""` | |
| tolerations | list | `[]` | |
| tolerations | list | `[]` | |
| route.enabled | bool | `false` | |
18 changes: 18 additions & 0 deletions infra/charts/feast-feature-server/templates/route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{{- if and (.Values.route.enabled) (eq .Values.feast_mode "ui") }}
---
kind: Route
apiVersion: route.openshift.io/v1
metadata:
name: {{ include "feast-feature-server.fullname" . }}
labels:
{{- include "feast-feature-server.labels" . | nindent 4 }}
spec:
to:
kind: Service
name: {{ include "feast-feature-server.fullname" . }}
port:
targetPort: http
tls:
termination: edge
insecureEdgeTerminationPolicy: Redirect
{{- end}}
4 changes: 4 additions & 0 deletions infra/charts/feast-feature-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,7 @@ livenessProbe:
readinessProbe:
initialDelaySeconds: 20
periodSeconds: 10

# to create OpenShift Route object for UI
route:
enabled: false