Skip to content

fix: Make transformation_service_endpoint configuration optional #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Jan 3, 2025
Merged

fix: Make transformation_service_endpoint configuration optional #4880

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3657593
Make transformation_service_endpoint configuration optional
xaniasd Dec 27, 2024
22ed81f
Add custom error for transformation service, implement featurestore u…
xaniasd Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make transformation_service_endpoint configuration optional 
Signed-off-by: Dimitris Stafylarakis <xanias@gmail.com>
  • Loading branch information
@xaniasd
xaniasd committed Jan 3, 2025
commit 36575937cfb2ed1aa6c5ab58b29a2ab51f711c0f
18 changes: 8 additions & 10 deletions go/internal/feast/featurestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ package feast
import (
"context"
"errors"
"fmt"

"github.com/apache/arrow/go/v17/arrow/memory"

//"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"

"github.com/feast-dev/feast/go/internal/feast/model"
Expand Down Expand Up @@ -60,17 +61,14 @@ func NewFeatureStore(config *registry.RepoConfig, callback transformation.Transf
return nil, err
}

// Use a scalable transformation service like Python Transformation Service.
// Assume the user will define the "transformation_service_endpoint" in the feature_store.yaml file
// under the "feature_server" section.
transformationServerEndpoint, ok := config.FeatureServer["transformation_service_endpoint"]
if !ok {
fmt.Println("Errors while reading transformation_service_endpoint info")
panic("No transformation service endpoint provided in the feature_store.yaml file.")
var transformationService *transformation.GrpcTransformationService
if transformationServerEndpoint, ok := config.FeatureServer["transformation_service_endpoint"]; ok {
// Use a scalable transformation service like Python Transformation Service.
// Assume the user will define the "transformation_service_endpoint" in the feature_store.yaml file
// under the "feature_server" section.
transformationService, _ = transformation.NewGrpcTransformationService(config, transformationServerEndpoint.(string))
}

transformationService, _ := transformation.NewGrpcTransformationService(config, transformationServerEndpoint.(string))

return &FeatureStore{
config: config,
registry: registry,
Expand Down