Skip to content

feat: Loading the CA trusted store certificate into Feast to verify the public certificate. #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 18 commits into from
Dec 18, 2024
Merged

feat: Loading the CA trusted store certificate into Feast to verify the public certificate. #4852

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f11ce84
Initial Draft version to load the CA trusted store code.
lokeshrangineni Dec 14, 2024
cc40246
Initial Draft version to load the CA trusted store code.
lokeshrangineni Dec 14, 2024
eda6900
Fixing the lint error.
lokeshrangineni Dec 14, 2024
abf4c7e
Trying to fix the online store test cases.
lokeshrangineni Dec 17, 2024
d497a9c
Merge branch 'master' into feature/adding-ca-store-support
lokeshrangineni Dec 17, 2024
767f241
Formatted the python to fix lint errors.
lokeshrangineni Dec 17, 2024
436f0db
Fixing the unit test cases.
lokeshrangineni Dec 17, 2024
1d64ebb
Fixing the unit test cases.
lokeshrangineni Dec 17, 2024
9540e7e
removing unnecessary cli args.
lokeshrangineni Dec 17, 2024
fff05f4
Now configuring the SSL ca store configurations on the feast client s…
lokeshrangineni Dec 17, 2024
36859bf
Renamed the remote registry is_tls_mode variable to is_tls.
lokeshrangineni Dec 17, 2024
9b6f8e5
Adding the existing trust store certificates to the newly created tru…
lokeshrangineni Dec 17, 2024
4a5de3b
Clearing the existing trust store configuration to see if it fixes th…
lokeshrangineni Dec 17, 2024
a6d3420
Clearing the existing trust store configuration to see if it fixes th…
lokeshrangineni Dec 17, 2024
706e9b4
Clearing the existing trust store configuration to see if it fixes th…
lokeshrangineni Dec 17, 2024
4970151
combining the default system ca store with the custom one to fix the …
lokeshrangineni Dec 18, 2024
f9aea9a
Final clean up and adding documentation.
lokeshrangineni Dec 18, 2024
6084fb9
Incorporating the code review comments from Francisco.
lokeshrangineni Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into feature/adding-ca-store-support
  • Loading branch information
@lokeshrangineni
lokeshrangineni authored Dec 17, 2024
commit d497a9c387d518c7f90e658e9bf5fdb811dd51dd
11 changes: 0 additions & 11 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,26 +1156,15 @@ def serve_registry_command(
show_default=False,
help="path to TLS certificate public key. You need to pass --key as well to start server in TLS mode",
)
@click.option(
"--ca",
"-ca",
"tls_ca_file_path",
type=click.STRING,
default="",
show_default=False,
help="path to ca trust store file. This will override the global path set as part of the environment variable FEAST_CA_CERT_FILE_PATH",
)
@click.pass_context
def serve_offline_command(
ctx: click.Context,
host: str,
port: int,
tls_key_path: str,
tls_cert_path: str,
tls_ca_file_path: str,
):
"""Start a remote server locally on a given host, port."""
configure_ssl_ca(ca_file_path=tls_ca_file_path)
if (tls_key_path and not tls_cert_path) or (not tls_key_path and tls_cert_path):
raise click.BadParameter(
"Please pass --cert and --key args to start the offline server in TLS mode."
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.