Skip to content

feat: Implement date_partition_column for SparkSource #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Dec 12, 2024
Merged

feat: Implement date_partition_column for SparkSource #4844

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0973653
Implement date_partition_column
niklasvm Dec 12, 2024
4d3a5de
fix unit tests
niklasvm Dec 12, 2024
434af73
add arg to docstring
niklasvm Dec 12, 2024
1b046e3
add unit tests that include a date_partition_column set
niklasvm Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix unit tests 
Signed-off-by: niklasvm <niklasvm@gmail.com>
  • Loading branch information
@niklasvm
niklasvm committed Dec 12, 2024
commit 4d3a5dececd591a7b74a6e1c663fa77112d2292e
3 changes: 1 addition & 2 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ def pull_latest_from_table_or_query(
SELECT {fields_as_string},
ROW_NUMBER() OVER({partition_by_join_key_string} ORDER BY {timestamp_desc_string}) AS feast_row_
FROM {from_expression} t1
WHERE {timestamp_field} BETWEEN TIMESTAMP('{start_date_str}') AND TIMESTAMP('{end_date_str}')
{"AND "+date_partition_column+" >= '"+start_date.strftime('%Y-%m-%d')+"' AND "+date_partition_column+" <= '"+end_date.strftime('%Y-%m-%d')+"' " if date_partition_column != "" and date_partition_column is not None else ''}
WHERE {timestamp_field} BETWEEN TIMESTAMP('{start_date_str}') AND TIMESTAMP('{end_date_str}'){"AND "+date_partition_column+" >= '"+start_date.strftime('%Y-%m-%d')+"' AND "+date_partition_column+" <= '"+end_date.strftime('%Y-%m-%d')+"' " if date_partition_column != "" and date_partition_column is not None else ''}
) t2
WHERE feast_row_ = 1
"""
Expand Down