Skip to content

feat: Removing the tls_verify_client flag from feast cli for offline server. #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 2 commits into from
Dec 16, 2024
Merged

feat: Removing the tls_verify_client flag from feast cli for offline server. #4842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1257c0
Removing the tls_verify_client flag for offline server from feast app…
lokeshrangineni Dec 12, 2024
4e8dbb3
fixing lint errors. formatted the code.
lokeshrangineni Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixing lint errors. formatted the code. 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
  • Loading branch information
@lokeshrangineni
lokeshrangineni committed Dec 12, 2024
commit 4e8dbb3a5aac1fe486e7001bf34b016dd6f1ff3f
4 changes: 1 addition & 3 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,9 +1968,7 @@ def serve_offline(
"""Start offline server locally on a given port."""
from feast import offline_server

offline_server.start_server(
self, host, port, tls_key_path, tls_cert_path
)
offline_server.start_server(self, host, port, tls_key_path, tls_cert_path)

def serve_transformations(self, port: int) -> None:
"""Start the feature transformation server locally on a given port."""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/offline_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def __init__(
str_to_auth_manager_type(store.config.auth_config.type)
),
tls_certificates=tls_certificates,
verify_client=False, # this is needed for when we don't need mTLS
verify_client=False, # this is needed for when we don't need mTLS
**kwargs,
)
self._location = location
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def setup(self, registry: RegistryConfig):
"--key",
str(tls_key_path),
"--cert",
str(self.tls_cert_path)
str(self.tls_cert_path),
]
self.proc = subprocess.Popen(
cmd, stdout=subprocess.PIPE, stderr=subprocess.DEVNULL
Expand Down