Skip to content

chore: Skip tests on doc updates #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmartinol merged 4 commits into from
Dec 11, 2024
Merged

chore: Skip tests on doc updates #4834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5160b2
feat: Make entity value_type mandatory with deprecation warning
devin-ai-integration[bot] Dec 11, 2024
5338764
style: Fix import sorting in entity files
devin-ai-integration[bot] Dec 11, 2024
7fd8781
Merge pull request #9 from franciscojavierarceo/devin/1733888469-mand…
franciscojavierarceo Dec 11, 2024
018d456
chore: Skip tests for community/docs/examples paths
devin-ai-integration[bot] Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Make entity value_type mandatory with deprecation warning 
- Add deprecation warning when value_type is not specified for an entity
- Add test cases to verify deprecation warning behavior
- Prepare for making value_type mandatory in next release

Issue: #4670

Co-Authored-By: Francisco Javier Arceo <arceofrancisco@gmail.com>
Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
  • Loading branch information
@devin-ai-integration @franciscojavierarceo
devin-ai-integration[bot] and franciscojavierarceo committed Dec 11, 2024
commit c5160b2c80770d45f91a56e8fa3e17efe4ac3c1b
8 changes: 8 additions & 0 deletions sdk/python/feast/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
from datetime import datetime
from typing import Dict, List, Optional
import warnings

from google.protobuf.json_format import MessageToJson
from typeguard import typechecked
Expand Down Expand Up @@ -79,6 +80,13 @@ def __init__(
ValueError: Parameters are specified incorrectly.
"""
self.name = name
if value_type is None:
warnings.warn(
"Entity value_type will be mandatory in the next release. "
"Please specify a value_type for entity '%s'." % name,
DeprecationWarning,
stacklevel=2,
)
self.value_type = value_type or ValueType.UNKNOWN

if join_keys and len(join_keys) > 1:
Expand Down
14 changes: 14 additions & 0 deletions sdk/python/tests/unit/test_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
import assertpy
import pytest
import warnings

from feast.entity import Entity
from feast.value_type import ValueType
Expand Down Expand Up @@ -73,3 +74,16 @@ def test_hash():

s4 = {entity1, entity2, entity3, entity4}
assert len(s4) == 3


def test_entity_without_value_type_warns():
with pytest.warns(DeprecationWarning, match="Entity value_type will be mandatory"):
entity = Entity(name="my-entity")
assert entity.value_type == ValueType.UNKNOWN


def test_entity_with_value_type_no_warning():
with warnings.catch_warnings():
warnings.simplefilter("error")
entity = Entity(name="my-entity", value_type=ValueType.STRING)
assert entity.value_type == ValueType.STRING