Skip to content

fix: Made fixes to Go Operator DB persistence #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 2 commits into from
Dec 11, 2024
Merged

fix: Made fixes to Go Operator DB persistence #4830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cab352
Made fixes to Go Operator DB persistence
tmihalac Dec 10, 2024
feedb20
Fixes following review
tmihalac Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes following review 
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
@tmihalac
tmihalac committed Dec 11, 2024
commit feedb207c4f28ff4368f3b24bbd3c1a7ef85d826
4 changes: 2 additions & 2 deletions infra/feast-operator/internal/controller/featurestore_controller_db_store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ sqlalchemy_config_kwargs:
pool_pre_ping: true
`

var invalidSecretContainingTypeYamlString = `
var secretContainingValidTypeYamlString = `
type: cassandra
hosts:
- 192.168.1.1
Expand Down Expand Up @@ -458,7 +458,7 @@ var _ = Describe("FeatureStore Controller - db storage services", func() {
secret := &corev1.Secret{}
err = k8sClient.Get(ctx, onlineSecretNamespacedName, secret)
Expect(err).NotTo(HaveOccurred())
secret.Data[string(services.OnlineDBPersistenceCassandraConfigType)] = []byte(invalidSecretContainingTypeYamlString)
secret.Data[string(services.OnlineDBPersistenceCassandraConfigType)] = []byte(secretContainingValidTypeYamlString)
Expect(k8sClient.Update(ctx, secret)).To(Succeed())

resource.Spec.Services.OnlineStore.Persistence.DBPersistence.SecretRef = corev1.LocalObjectReference{Name: "online-store-secret"}
Expand Down