Skip to content

feat: Add online/offline replica support #4812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 5 commits into from
Dec 11, 2024
Merged

feat: Add online/offline replica support #4812

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5453501
added replica support to online/offline store services
dandawg Dec 11, 2024
45349a4
Removed unneaded if statement
dandawg Dec 11, 2024
25e3092
fixed missing bracket
dandawg Dec 11, 2024
62bc81b
added doc comments describing replicas
dandawg Dec 11, 2024
2f26c94
Replicas doc wording change
dandawg Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added doc comments describing replicas 
Signed-off-by: dandawg <12484302+dandawg@users.noreply.github.com>
  • Loading branch information
@dandawg
dandawg committed Dec 11, 2024
commit 62bc81b3189ccfc831998d52ff5b9e8cacf85dd7
3 changes: 3 additions & 0 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,10 @@ type DefaultConfigs struct {
Image *string `json:"image,omitempty"`
}

// StoreServiceConfigs k8s deployment settings
type StoreServiceConfigs struct {
// Replicas determines the number of pods for the feast service.
// When Replicas > 1, persistence should be configured to provide central storage
Comment thread
tchughesiv marked this conversation as resolved.
Outdated
Replicas *int32 `json:"replicas,omitempty"`
Comment thread
tchughesiv marked this conversation as resolved.
ServiceConfigs `json:",inline"`
}
Expand Down
12 changes: 12 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,9 @@ spec:
- message: One selection required between file or store.
rule: '[has(self.file), has(self.store)].exists_one(c, c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -749,6 +752,9 @@ spec:
- message: One selection required between file or store.
rule: '[has(self.file), has(self.store)].exists_one(c, c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -1621,6 +1627,9 @@ spec:
rule: '[has(self.file), has(self.store)].exists_one(c,
c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -2007,6 +2016,9 @@ spec:
rule: '[has(self.file), has(self.store)].exists_one(c,
c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down
12 changes: 12 additions & 0 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ spec:
- message: One selection required between file or store.
rule: '[has(self.file), has(self.store)].exists_one(c, c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -757,6 +760,9 @@ spec:
- message: One selection required between file or store.
rule: '[has(self.file), has(self.store)].exists_one(c, c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -1629,6 +1635,9 @@ spec:
rule: '[has(self.file), has(self.store)].exists_one(c,
c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down Expand Up @@ -2015,6 +2024,9 @@ spec:
rule: '[has(self.file), has(self.store)].exists_one(c,
c)'
replicas:
description: |-
Replicas determines the number of pods for the feast service.
When Replicas > 1, persistence should be configured to provide central storage
format: int32
type: integer
resources:
Expand Down