Skip to content

feat: Feast Operator support log level configuration for services #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 7 commits into from
Dec 5, 2024
Merged

feat: Feast Operator support log level configuration for services #4808

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7af314
fix: Feast Operator updated the kustomize version to v5.5.0
redhatHameed Dec 2, 2024
609e9a8
feat : Feast Operator support log level configuration for services
redhatHameed Dec 3, 2024
94acc49
Update infra/feast-operator/internal/controller/services/services.go
redhatHameed Dec 4, 2024
7ea29c5
Update infra/feast-operator/internal/controller/services/services.go
redhatHameed Dec 4, 2024
9fb5339
added unit test for loglevel
redhatHameed Dec 4, 2024
fa79e95
fix the loglevel command
redhatHameed Dec 5, 2024
fc4fc79
moved the logLevel under LocalRegistryConfig and updated testcase to …
redhatHameed Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the loglevel command 
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
  • Loading branch information
@redhatHameed
redhatHameed committed Dec 5, 2024
commit fa79e952097cd6467bb1820c6ae3f3f78ce871dc
17 changes: 17 additions & 0 deletions infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
name: sample-services-loglevel
spec:
feastProject: my_project
services:
onlineStore:
logLevel: debug
offlineStore:
logLevel: debug
registry:
logLevel: info
local:
persistence:
file:
path: /data/registry.db
Comment thread
tchughesiv marked this conversation as resolved.
Outdated
21 changes: 14 additions & 7 deletions infra/feast-operator/internal/controller/services/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,29 +355,36 @@ func (feast *FeastServices) setDeployment(deploy *appsv1.Deployment, feastType F
}

func (feast *FeastServices) getContainerCommand(feastType FeastServiceType) []string {
deploySettings := FeastServiceConstants[feastType]
targetPort := deploySettings.TargetHttpPort
baseCommand := "feast"
options := []string{}
logLevel := feast.getLogLevelForType(feastType)
if logLevel != nil {
deploySettings.Command = append(deploySettings.Command, []string{"--log-level", strings.ToUpper(*logLevel)}...)
options = append(options, "--log-level", strings.ToUpper(*logLevel))
}

deploySettings := FeastServiceConstants[feastType]
targetPort := deploySettings.TargetHttpPort
tls := feast.getTlsConfigs(feastType)
if tls.IsTLS() {
targetPort = deploySettings.TargetHttpsPort
feastTlsPath := GetTlsPath(feastType)
deploySettings.Command = append(deploySettings.Command, []string{"--key", feastTlsPath + tls.SecretKeyNames.TlsKey,
deploySettings.Args = append(deploySettings.Args, []string{"--key", feastTlsPath + tls.SecretKeyNames.TlsKey,
"--cert", feastTlsPath + tls.SecretKeyNames.TlsCrt}...)
}
deploySettings.Command = append(deploySettings.Command, []string{"-p", strconv.Itoa(int(targetPort))}...)
deploySettings.Args = append(deploySettings.Args, []string{"-p", strconv.Itoa(int(targetPort))}...)

if feastType == OfflineFeastType {
if tls.IsTLS() && feast.Handler.FeatureStore.Status.Applied.Services.OfflineStore.TLS.VerifyClient != nil {
deploySettings.Command = append(deploySettings.Command,
deploySettings.Args = append(deploySettings.Args,
[]string{"--verify_client", strconv.FormatBool(*feast.Handler.FeatureStore.Status.Applied.Services.OfflineStore.TLS.VerifyClient)}...)
}
}

return deploySettings.Command
// Combine base command, options, and arguments
feastCommand := append([]string{baseCommand}, options...)
feastCommand = append(feastCommand, deploySettings.Args...)

return feastCommand
}

func (feast *FeastServices) offlineClientPodConfigs(podSpec *corev1.PodSpec) {
Expand Down
8 changes: 4 additions & 4 deletions infra/feast-operator/internal/controller/services/services_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,17 @@ var (

FeastServiceConstants = map[FeastServiceType]deploymentSettings{
OfflineFeastType: {
Command: []string{"feast", "serve_offline", "-h", "0.0.0.0"},
Args: []string{"serve_offline", "-h", "0.0.0.0"},
TargetHttpPort: 8815,
TargetHttpsPort: 8816,
},
OnlineFeastType: {
Command: []string{"feast", "serve", "-h", "0.0.0.0"},
Args: []string{"serve", "-h", "0.0.0.0"},
TargetHttpPort: 6566,
TargetHttpsPort: 6567,
},
RegistryFeastType: {
Command: []string{"feast", "serve_registry"},
Args: []string{"serve_registry"},
TargetHttpPort: 6570,
TargetHttpsPort: 6571,
},
Expand Down Expand Up @@ -234,7 +234,7 @@ type AuthzConfig struct {
}

type deploymentSettings struct {
Command []string
Args []string
TargetHttpPort int32
TargetHttpsPort int32
}