Skip to content

feat: Add TLS support to the Operator #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmartinol merged 4 commits into from
Dec 2, 2024
Merged

feat: Add TLS support to the Operator #4796

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
727883c
add tls support to the operator
tchughesiv Nov 19, 2024
274eb6a
operator tls review fix: if statement
tchughesiv Dec 1, 2024
648f519
rebase fixes
tchughesiv Dec 1, 2024
d4c3229
authz rbac fixes
tchughesiv Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
operator tls review fix: if statement 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
@tchughesiv
tchughesiv committed Dec 1, 2024
commit 274eb6a92053ed39235ed3e0a8fd207568d9a03c
8 changes: 5 additions & 3 deletions infra/feast-operator/internal/controller/services/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ func (feast *FeastServices) Deploy() error {
if err := feast.ApplyDefaults(); err != nil {
Comment thread
lokeshrangineni marked this conversation as resolved.
Outdated
return err
}
if openshiftTls, err := feast.checkOpenshiftTls(); openshiftTls {
openshiftTls, err := feast.checkOpenshiftTls()
if err != nil {
return err
}
if openshiftTls {
if err := feast.createCaConfigMap(); err != nil {
return err
}
} else if err != nil {
return err
} else {
_ = feast.Handler.DeleteOwnedFeastObj(feast.initCaConfigMap())
}
Expand Down