Repository navigation
chore: Removed unneeded install line - #4782
Merged
franciscojavierarceo merged 1 commit intoNov 22, 2024
Merged
Conversation
Signed-off-by: dandawg <12484302+dandawg@users.noreply.github.com>
dmartinol
approved these changes
Nov 22, 2024
franciscojavierarceo
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the command
pip install Pygments -q(and a supporting comment) from thequickstart.ipynbnotebook. This install command is not needed becausePygmentsis afeastdependency that is installed withfeast. Removing the extra install line simplifies the notebook and makes it easier to get started quickly, as it makes the cell run faster.Which issue(s) this PR fixes:
Misc
To test that the notebook still works you can:
quickstart.ipynbfrom this PR (with the Pygments import statement removed). It should run successfully.Note that the notebook itself installs
feastlatest. You can verify thatpygmentsis an explicit dependency of feast with: