Skip to content

feat: Add Milvus Vector Database Implementation #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 33 commits into from
Dec 24, 2024
Merged

feat: Add Milvus Vector Database Implementation #4751

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ab7d4fb
merged rebase
franciscojavierarceo Dec 9, 2024
a6c9005
adding configuration
franciscojavierarceo Nov 11, 2024
b61b965
updated
franciscojavierarceo Nov 12, 2024
88bca02
changed things and linted
franciscojavierarceo Nov 15, 2024
81bd84a
adding updated builds
franciscojavierarceo Nov 15, 2024
083fe67
adding repo config
franciscojavierarceo Nov 20, 2024
fcf32d9
updated
franciscojavierarceo Nov 25, 2024
662119a
renaming test and adding milvus to integration test
franciscojavierarceo Nov 27, 2024
4a7edd8
not quite working but have milvus talking
franciscojavierarceo Nov 27, 2024
4c16c0b
updated tests
franciscojavierarceo Dec 1, 2024
fabac18
apply() method now works
franciscojavierarceo Dec 2, 2024
2ee74c5
updated setup
franciscojavierarceo Dec 9, 2024
1859e76
checking in progresss...getting there
franciscojavierarceo Dec 13, 2024
35557ce
making some progress
franciscojavierarceo Dec 14, 2024
c54309a
partially running
franciscojavierarceo Dec 15, 2024
0094e27
checking in progress...finding issues still
franciscojavierarceo Dec 16, 2024
25a065e
have the apply working
franciscojavierarceo Dec 16, 2024
f1a92e0
adjusting some type issues
franciscojavierarceo Dec 16, 2024
3282a05
updated and removed test
franciscojavierarceo Dec 16, 2024
2dee462
have things behaving with the enviornment arg
franciscojavierarceo Dec 17, 2024
be8c5bc
updated milvus
franciscojavierarceo Dec 17, 2024
dbc11e2
almost have retrieval working, having to make a lot of changes to onl…
franciscojavierarceo Dec 18, 2024
37d93f1
almost have deserialization from the search results done
franciscojavierarceo Dec 19, 2024
67ad688
got the retrieval working now too :D
franciscojavierarceo Dec 19, 2024
d1c15cf
updates to fix linter and new signature for all implementations
franciscojavierarceo Dec 20, 2024
6d94d7a
linter
franciscojavierarceo Dec 20, 2024
fe518ed
more linting
franciscojavierarceo Dec 20, 2024
a639013
Removing some unnecessary code
franciscojavierarceo Dec 20, 2024
c91681f
removing change to setup
franciscojavierarceo Dec 20, 2024
bd5ff48
adding sphinx docs
franciscojavierarceo Dec 20, 2024
32c9a9f
adjusting workflow
franciscojavierarceo Dec 23, 2024
22bac8b
adding logging to debug
franciscojavierarceo Dec 23, 2024
134b908
changing to vectordb environment
franciscojavierarceo Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more linting 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Dec 22, 2024
commit fe518ed9cda3909f071fd97f9946a1dcc80ba58e
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
FieldSchema,
connections,
)
from pymilvus.orm.connections import Connections

from feast import Entity
from feast.feature_view import FeatureView
Expand Down Expand Up @@ -102,7 +103,7 @@ class MilvusOnlineStore(OnlineStore):
_collections: Dictionary to cache Milvus collections.
"""

_conn: Optional[connections] = None
_conn: Optional[Connections] = None
_collections: Dict[str, Collection] = {}

def _connect(self, config: RepoConfig) -> connections:
Expand Down