Skip to content

feat!: Refactor online stores by removing the contrib directory. (Breaking imports) #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Nov 7, 2024
Merged

feat!: Refactor online stores by removing the contrib directory. (Breaking imports) #4731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d569be
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
1d6c312
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
24fd7de
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
13620e8
feat: Refactor online store by removing the contrib directory
HaoXuAI Nov 2, 2024
537cdd7
fix legacy mapping
HaoXuAI Nov 4, 2024
568dea0
fix legacy mapping
HaoXuAI Nov 4, 2024
4dc93c5
fix conflict
HaoXuAI Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Refactor online store by removing the contrib directory 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Nov 2, 2024
commit 1d6c3127cb48a9fa52a994c7fd214bb05b351aa0
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ test-python-universal-postgres-offline:

test-python-universal-postgres-online:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.postgres_repo_configuration \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.postgres_online_store.postgres_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.postgres \
python -m pytest -n 8 --integration \
-k "not test_universal_cli and \
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/online-stores/postgres.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ online_store:
```
{% endcode %}

The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.postgres.PostgreSQLOnlineStoreConfig).
The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig).

## Functionality Matrix

Expand Down Expand Up @@ -79,7 +79,7 @@ For the Retrieval Augmented Generation (RAG) use-case, you have to embed the qu
{% code title="python" %}
```python
from feast import FeatureStore
from feast.infra.online_stores.postgres import retrieve_online_documents
from feast.infra.online_stores.postgres_online_store import retrieve_online_documents

feature_store = FeatureStore(repo_path=".")

Expand Down
4 changes: 2 additions & 2 deletions sdk/python/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,10 @@ Snowflake Online Store
PostgreSQL Online Store
-----------------------

.. autoclass:: feast.infra.online_stores.postgres.PostgreSQLOnlineStore
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStore
:members:

.. autoclass:: feast.infra.online_stores.postgres.PostgreSQLOnlineStoreConfig
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig
:members:

HBase Online Store
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/docs/source/feast.infra.online_stores.contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ feast.infra.online\_stores.contrib.pgvector\_repo\_configuration module
feast.infra.online\_stores.contrib.postgres module
--------------------------------------------------

.. automodule:: feast.infra.online_stores.postgres
.. automodule:: feast.infra.online_stores.postgres_online_store
:members:
:undoc-members:
:show-inheritance:

feast.infra.online\_stores.contrib.postgres\_repo\_configuration module
-----------------------------------------------------------------------

.. automodule:: feast.infra.online_stores.postgres_repo_configuration
.. automodule:: feast.infra.online_stores.postgres_online_store.postgres_repo_configuration
:members:
:undoc-members:
:show-inheritance:
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/docs/source/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,10 @@ Snowflake Online Store
PostgreSQL Online Store
-----------------------

.. autoclass:: feast.infra.online_stores.postgres.PostgreSQLOnlineStore
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStore
:members:

.. autoclass:: feast.infra.online_stores.postgres.PostgreSQLOnlineStoreConfig
.. autoclass:: feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig
:members:

HBase Online Store
Expand Down
0 .../infra/online_stores/postgres/__init__.py → ..._stores/postgres_online_store/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...s/postgres/pgvector_repo_configuration.py → ...line_store/pgvector_repo_configuration.py
View file
Open in desktop
File renamed without changes.
0 .../infra/online_stores/postgres/postgres.py → ..._stores/postgres_online_store/postgres.py
View file
Open in desktop
File renamed without changes.
0 ...s/postgres/postgres_repo_configuration.py → ...line_store/postgres_repo_configuration.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"dynamodb": "feast.infra.online_stores.dynamodb.DynamoDBOnlineStore",
"snowflake.online": "feast.infra.online_stores.snowflake.SnowflakeOnlineStore",
"bigtable": "feast.infra.online_stores.bigtable.BigtableOnlineStore",
"postgres": "feast.infra.online_stores.postgres.PostgreSQLOnlineStore",
"postgres": "feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStore",
"hbase": "feast.infra.online_stores.hbase_online_store.hbase.HbaseOnlineStore",
"cassandra": "feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStore",
"mysql": "feast.infra.online_stores.mysql_online_store.mysql.MySQLOnlineStore",
Expand Down