Skip to content

feat: Adding support for native Python transformations on a single dictionary #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 5 commits into from
Nov 6, 2024
Merged

feat: Adding support for native Python transformations on a single dictionary #4724

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5617321
feat: Adding support for native Python transformations on a dictionary
franciscojavierarceo Oct 31, 2024
c514a4d
Updated type checking and added exception handling to try basic dict.…
franciscojavierarceo Oct 31, 2024
237e32e
updated tests
franciscojavierarceo Nov 5, 2024
71927f5
adding protos
franciscojavierarceo Nov 5, 2024
7bf426c
fixed unit test
franciscojavierarceo Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Adding support for native Python transformations on a dictionary 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Nov 5, 2024
commit 5617321491f7975a405cb4abe3b4aa2173481235
49 changes: 34 additions & 15 deletions sdk/python/tests/unit/test_on_demand_python_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,28 +204,14 @@ def python_stored_writes_feature_view(
}
return output

with pytest.raises(TypeError):
# Note the singleton view will fail as the type is
# expected to be a list which can be confirmed in _infer_features_dict
self.store.apply(
[
driver,
driver_stats_source,
driver_stats_fv,
pandas_view,
python_view,
python_singleton_view,
driver_stats_entity_less_fv,
]
)

self.store.apply(
[
driver,
driver_stats_source,
driver_stats_fv,
pandas_view,
python_view,
python_singleton_view,
python_demo_view,
driver_stats_entity_less_fv,
python_stored_writes_feature_view,
Expand All @@ -244,6 +230,39 @@ def python_stored_writes_feature_view(
assert len(self.store.list_on_demand_feature_views()) == 4
assert len(self.store.list_stream_feature_views()) == 0

def test_setup(self):
pass

def test_python_singleton_view(self):
entity_rows = [
{
"driver_id": 1001,
}
]

online_python_response = self.store.get_online_features(
entity_rows=entity_rows,
features=[
"driver_hourly_stats:conv_rate",
"driver_hourly_stats:acc_rate",
"python_singleton_view:conv_rate_plus_acc_python_singleton",
],
).to_dict()

assert sorted(list(online_python_response.keys())) == sorted(
[
"driver_id",
"acc_rate",
"conv_rate",
"conv_rate_plus_acc_python_singleton",
]
)

assert online_python_response["conv_rate_plus_acc_python_singleton"][0] == (
online_python_response["conv_rate"][0]
+ online_python_response["acc_rate"][0]
)

def test_python_pandas_parity(self):
entity_rows = [
{
Expand Down