Skip to content

feat: Add api contract to fastapi docs #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 3 commits into from
Nov 5, 2024
Merged

feat: Add api contract to fastapi docs #4721

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad98954
use pydantic models to populate fastapi docs
robhowley Oct 30, 2024
1981a87
fix feature service feature assignment
robhowley Oct 30, 2024
720b6bf
add response types, mostly none
robhowley Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix feature service feature assignment 
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
@robhowley
robhowley committed Oct 30, 2024
commit 1981a870666d828c8703af2cf51f45b0541fedfb
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ async def get_online_features(request: GetOnlineFeaturesRequest):
assert_permissions(
resource=feature_service, actions=[AuthzedAction.READ_ONLINE]
)
features = request.feature_service # type: ignore
features = feature_service # type: ignore
else:
all_feature_views, all_on_demand_feature_views = (
utils._get_feature_views_to_use(
Expand Down