Skip to content

feat: Adding SSL support for online server #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Oct 25, 2024
Merged

feat: Adding SSL support for online server #4677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c054f9
* Adding the SSL support for online_server.
lokeshrangineni Oct 25, 2024
2b000ee
Incorporating code review comment.
lokeshrangineni Oct 25, 2024
f2482a9
Update docs/reference/feature-servers/python-feature-server.md
lokeshrangineni Oct 25, 2024
1ca37f3
* Update docs/reference/feature-servers/python-feature-server.md
lokeshrangineni Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Incorporating code review comment. 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>

incorporating code review comments.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
  • Loading branch information
@lokeshrangineni
lokeshrangineni committed Oct 25, 2024
commit 2b000ee1648e1aef4db56f647c1c5e38d3f998ef
4 changes: 3 additions & 1 deletion docs/reference/feature-servers/python-feature-server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,10 @@ requests.post(

## Starting the feature server in SSL mode
Comment thread
lokeshrangineni marked this conversation as resolved.

Enabling SSL mode ensures that data between the Feast client and server is transmitted securely. For an ideal production environment, it’s recommended to start the feature server in SSL mode.
Comment thread
lokeshrangineni marked this conversation as resolved.
Outdated

### Obtaining a self-signed SSL certificate and key
In development mode we can generate a self-signed certificate for testing. In an actual production environment it is always recommended to get it from an SSL certificate provider.
In development mode we can generate a self-signed certificate for testing. In an actual production environment it is always recommended to get it from a trusted SSL certificate provider.

```shell
openssl req -x509 -newkey rsa:2048 -keyout key.pem -out cert.pem -days 365 -nodes
Expand Down