Skip to content

perf: Implement dynamo write_batch_async #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 19 commits into from
Oct 24, 2024
Merged

perf: Implement dynamo write_batch_async #4675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
87d59fe
rebase
robhowley Oct 23, 2024
7793d99
offline store init doesnt make sense
robhowley Oct 17, 2024
f04711e
dont init or close
robhowley Oct 23, 2024
d1094ad
update test to handle event loop for dynamo case
robhowley Oct 23, 2024
afaa412
use run util complete
robhowley Oct 23, 2024
2245caa
fix: spelling sigh
robhowley Oct 23, 2024
eebf71d
run integration test as async since that is default for read
robhowley Oct 24, 2024
e593c1a
add pytest async to ci reqs
robhowley Oct 24, 2024
f50c6cb
be safe w cleanup in test fixture
robhowley Oct 24, 2024
5c4a88a
be safe w cleanup in test fixture
robhowley Oct 24, 2024
92dc4bd
update pytest ini
robhowley Oct 24, 2024
ee2249a
not in a finally
robhowley Oct 24, 2024
5c69273
remove close
robhowley Oct 24, 2024
385e3ea
test client is a lifespan aware context manager
robhowley Oct 24, 2024
7fdc291
Merge branch 'feast-dev:master' into master
robhowley Oct 24, 2024
7991146
add async writer for dynamo
robhowley Oct 24, 2024
b381892
fix dynamo client put item format
robhowley Oct 24, 2024
4b0378e
clarify documentation
robhowley Oct 24, 2024
24d203d
add deduplication to async dynamo write
robhowley Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
offline store init doesnt make sense 
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
@robhowley
robhowley committed Oct 23, 2024
commit 7793d99f3f39b834f87b3f3818757025031011f2
6 changes: 0 additions & 6 deletions sdk/python/feast/infra/offline_stores/offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,3 @@ def get_table_column_names_and_types_from_data_source(
data_source: DataSource object
"""
return data_source.get_table_column_names_and_types(config=config)

async def initialize(self, config: RepoConfig) -> None:
pass

async def close(self) -> None:
pass
2 changes: 0 additions & 2 deletions sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,6 @@ def get_table_column_names_and_types_from_data_source(

async def initialize(self, config: RepoConfig) -> None:
await self.online_store.initialize(config)
await self.offline_store.initialize(config)

async def close(self) -> None:
await self.online_store.close()
await self.offline_store.close()