Skip to content

feat: Update the go feature server from Expedia code repo. #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 10 commits into from
Dec 4, 2024
Merged

feat: Update the go feature server from Expedia code repo. #4665

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df2f0a6
feat: Update the go feature server from Expedia code repo.
shuchu Oct 22, 2024
be909c3
fix: Add go package definition to RegistryServer and Grpcserver.
shuchu Oct 23, 2024
23a8156
fix: Fix the make build-go
shuchu Oct 23, 2024
37b7266
fix: Fix makefile to make test-go work.
shuchu Nov 1, 2024
20aefa9
fix: Removed and commented out DataDog related observability instrume…
shuchu Nov 1, 2024
b9eff42
doc: Update the README to mention the contirbution from Expedia Group.
shuchu Nov 1, 2024
4eaa6c7
fix: Remove the HTTP based Registry.
shuchu Nov 5, 2024
953d62e
fix: Use a general string to represent the transformation service end…
shuchu Nov 21, 2024
63dcefa
fix: Set the transformation service endpoint defintion to feature_sto…
shuchu Nov 25, 2024
8e4893c
fix: Fix few format issues.
shuchu Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix makefile to make test-go work. 
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
  • Loading branch information
@shuchu
shuchu committed Nov 21, 2024
commit 37b7266c8a0a2caf793ebfedfef0b3eaa14cbfb9
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,9 @@ install-go-ci-dependencies:
build-go: compile-protos-go
Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the inline seems to be at odds with the rest of the Makefile format, could you adjust it?

Copy link
Copy Markdown
Collaborator Author

@shuchu shuchu Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

go build -o feast ./go/main.go

install-feast-ci-locally:
pip install -e ".[ci]"

test-go: compile-protos-go compile-protos-python install-feast-ci-locally
Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Copy Markdown
Collaborator Author

@shuchu shuchu Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CGO_ENABLED=1 go test -coverprofile=coverage.out ./... && go tool cover -html=coverage.out -o coverage.html

Expand Down