Skip to content

fix: Bigquery dataset create table disposition #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 6 commits into from
Oct 21, 2024
Merged

fix: Bigquery dataset create table disposition #4649

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59c33a8
fix: adding self to a method which is failing linting in file.py inte…
danbaron63 Oct 18, 2024
41b01e1
fix: added create_table_disposition check when creating a dataset whe…
danbaron63 Oct 18, 2024
f8d65fa
fix: ignoring some mypy linting errors caused by expanding a dict int…
danbaron63 Oct 18, 2024
678f7e7
ignoring typing in auth_permissions_util that would be unreasonable t…
danbaron63 Oct 18, 2024
cdb8539
fixing method declaration that has no self parameter
danbaron63 Oct 18, 2024
c2f3a74
made xdist_group methods static
danbaron63 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing method declaration that has no self parameter 
Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
  • Loading branch information
@danbaron63
danbaron63 committed Oct 18, 2024
commit cdb8539fdc3d4144b7e0fe91521eba4005196e56
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_source_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ def create_logged_features_destination(self) -> LoggingDestination:
def teardown(self):
raise NotImplementedError

def xdist_groups() -> list[str]:
def xdist_groups(self) -> list[str]:
return []