Skip to content

perf: Add init and cleanup of long lived resources #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 14 commits into from
Oct 24, 2024
Merged

perf: Add init and cleanup of long lived resources #4642

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
87d59fe
rebase
robhowley Oct 23, 2024
7793d99
offline store init doesnt make sense
robhowley Oct 17, 2024
f04711e
dont init or close
robhowley Oct 23, 2024
d1094ad
update test to handle event loop for dynamo case
robhowley Oct 23, 2024
afaa412
use run util complete
robhowley Oct 23, 2024
2245caa
fix: spelling sigh
robhowley Oct 23, 2024
eebf71d
run integration test as async since that is default for read
robhowley Oct 24, 2024
e593c1a
add pytest async to ci reqs
robhowley Oct 24, 2024
f50c6cb
be safe w cleanup in test fixture
robhowley Oct 24, 2024
5c4a88a
be safe w cleanup in test fixture
robhowley Oct 24, 2024
92dc4bd
update pytest ini
robhowley Oct 24, 2024
ee2249a
not in a finally
robhowley Oct 24, 2024
5c69273
remove close
robhowley Oct 24, 2024
385e3ea
test client is a lifespan aware context manager
robhowley Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use run util complete 
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
@robhowley
robhowley committed Oct 23, 2024
commit afaa4120107e9eddb3e9acd781a57021b5ceda4b
4 changes: 2 additions & 2 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ def async_refresh():
@asynccontextmanager
async def lifespan(app: FastAPI):
async_refresh()
# await store.initialize()
await store.initialize()
Comment thread
robhowley marked this conversation as resolved.
yield
stop_refresh()
# await store.close()
await store.close()
Comment on lines +103 to +107
Copy link
Copy Markdown
Contributor Author

@robhowley robhowley Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can create and cleanup resources as part of the feature server lifespan

Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this and let's rerun the integration test? Or maybe create a separate branch without it?


app = FastAPI(lifespan=lifespan)

Expand Down
5 changes: 3 additions & 2 deletions sdk/python/tests/integration/online_store/test_python_feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ def python_fs_client(environment, universal_data_sources, request):
feast_objects.extend([driver(), customer(), location()])
fs.apply(feast_objects)
fs.materialize(environment.start_date, environment.end_date)
asyncio.run(fs.initalize())
loop = asyncio.get_event_loop()
loop.run_until_complete(fs.initalize())
client = TestClient(get_app(fs))
yield client
asyncio.run(fs.close())
loop.run_until_complete(fs.close())