Skip to content

fix: Quickstart documentation changes #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Oct 21, 2024
Merged

fix: Quickstart documentation changes #4618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcde20c
fix: changes following issue 4593
tmihalac Oct 11, 2024
49ec7a7
fix: changes following issue 4593
tmihalac Oct 14, 2024
f658b50
docs: updated following review
tmihalac Oct 17, 2024
7597fe6
Updated documents following review suggestions
tmihalac Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: changes following issue 4593 
- Reverted Fixed file path in templates to be relative path

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
@tmihalac
tmihalac committed Oct 14, 2024
commit 49ec7a74cffa63eed843063fe67c8e9f04ed2561
4 changes: 1 addition & 3 deletions sdk/python/feast/templates/cassandra/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,7 @@ def bootstrap():

# example_repo.py
example_py_file = repo_path / "example_repo.py"
replace_str_in_file(
example_py_file, "%PARQUET_PATH%", str(driver_stats_path.relative_to(repo_path))
)
replace_str_in_file(example_py_file, "%PARQUET_PATH%", str(driver_stats_path))

# store config yaml, interact with user and then customize file:
settings = collect_cassandra_store_settings()
Expand Down
4 changes: 1 addition & 3 deletions sdk/python/feast/templates/hazelcast/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ def bootstrap():

# example_repo.py
example_py_file = repo_path / "example_repo.py"
replace_str_in_file(
example_py_file, "%PARQUET_PATH%", str(driver_stats_path.relative_to(repo_path))
)
replace_str_in_file(example_py_file, "%PARQUET_PATH%", str(driver_stats_path))

# store config yaml, interact with user and then customize file:
settings = collect_hazelcast_online_store_settings()
Expand Down
4 changes: 1 addition & 3 deletions sdk/python/feast/templates/hbase/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ def bootstrap():
driver_df.to_parquet(path=str(driver_stats_path), allow_truncated_timestamps=True)

example_py_file = repo_path / "example_repo.py"
replace_str_in_file(
example_py_file, "%PARQUET_PATH%", str(driver_stats_path.relative_to(repo_path))
)
replace_str_in_file(example_py_file, "%PARQUET_PATH%", str(driver_stats_path))


if __name__ == "__main__":
Expand Down
8 changes: 2 additions & 6 deletions sdk/python/feast/templates/local/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,8 @@ def bootstrap():

example_py_file = repo_path / "example_repo.py"
replace_str_in_file(example_py_file, "%PROJECT_NAME%", str(project_name))
replace_str_in_file(
example_py_file, "%PARQUET_PATH%", str(driver_stats_path.relative_to(repo_path))
)
replace_str_in_file(
example_py_file, "%LOGGING_PATH%", str(data_path.relative_to(repo_path))
)
replace_str_in_file(example_py_file, "%PARQUET_PATH%", str(driver_stats_path))
replace_str_in_file(example_py_file, "%LOGGING_PATH%", str(data_path))


if __name__ == "__main__":
Expand Down