Skip to content

feat: Add boto3 session based auth for dynamodb online store for cross account access #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 6 commits into from
Oct 10, 2024
Merged

feat: Add boto3 session based auth for dynamodb online store for cross account access #4606

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0149712
added session auth for dynamodb online store
asingh9530 Oct 5, 2024
c307da7
lint
asingh9530 Oct 5, 2024
9a29b10
Update sdk/python/feast/infra/online_stores/dynamodb.py
asingh9530 Oct 5, 2024
8c7f0d6
Update sdk/python/feast/infra/online_stores/dynamodb.py
asingh9530 Oct 5, 2024
3a4597d
dummy commit
asingh9530 Oct 6, 2024
054c1a6
dummy commit
asingh9530 Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update sdk/python/feast/infra/online_stores/dynamodb.py 
Co-authored-by: Francisco Arceo <farceo@redhat.com>
Signed-off-by: asingh9530 <abhinav199530singh@gmail.com>
  • Loading branch information
@asingh9530 @franciscojavierarceo
asingh9530 and franciscojavierarceo committed Oct 5, 2024
commit 9a29b10687913ff24b86846d9380fecc61f5f787
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/online_stores/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def _initialize_dynamodb_client(
endpoint_url: Optional[str] = None,
session_based_auth: Optional[bool] = False,
):
if session_based_auth is True:
if session_based_auth:
return boto3.Session().client(
"dynamodb",
region_name=region,
Expand Down