Skip to content

chore!: Update @elastic/eui and @emotion/react in Feast UI #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Oct 6, 2024
Merged

chore!: Update @elastic/eui and @emotion/react in Feast UI #4597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76c77e1
chore!: Update @elastic/eui and @emotion/react to latest versions
peruukki Sep 28, 2024
1548968
chore: Update Node version from 17 to 20 in UI unit tests
peruukki Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Update Node version from 17 to 20 in UI unit tests 
Node 17 is not an LTS (long-term support) version and apparently
rejected by the latest versions of Elastic UI:

> error @elastic/eui@95.12.0: The engine "node" is incompatible with
> this module. Expected version "16.x || 18.x || >=20.x". Got "17.9.1"

Let's try with the latest LTS version.

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
  • Loading branch information
@peruukki
peruukki committed Oct 3, 2024
commit 154896826fad03c147bc136c4dd721247c45e3ba
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: '17.x'
node-version: '20.x'
registry-url: 'https://registry.npmjs.org'
- name: Install yarn dependencies
working-directory: ./ui
Expand Down