Skip to content

fix: Fix vector store config #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Sep 28, 2024
Merged

fix: Fix vector store config #4583

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e10aea
refactor vector store config
HaoXuAI Sep 28, 2024
f09748e
refactor vector store config
HaoXuAI Sep 28, 2024
245bc36
fix lint
HaoXuAI Sep 28, 2024
c1da697
fix lint
HaoXuAI Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor vector store config 
Signed-off-by: cmuhao <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Sep 28, 2024
commit f09748ef14387ce9cf464ae27cde562653c6e4d5
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/online_stores/vector_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from typing import Optional


class VectorStoreConfig:
Expand All @@ -11,4 +12,4 @@ class VectorStoreConfig:

# The vector similarity metric to use in KNN search
# more details: https://www.elastic.co/guide/en/elasticsearch/reference/current/dense-vector.html
similarity: Optional[str] = "cosine"
similarity: Optional[str] = "cosine"