Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Remove unnecessary peer dependencies from Feast UI
Rationale:

### Clear peer dependencies

react, react-dom: These are needed for any React web app, and having a
single React version across your app is highly recommended.

### Possible peer dependencies

@elastic/eui, @emotion/react: If you are adding custom tabs, it makes
sense to use the same component library and CSS-in-JS solution as Feast UI,
and preferably the same versions and/or single instances (though I don't
know how important that is). Though using only @elastic/eui of these may
well be enough.

And you don't need these if you only want a custom projectListPromise. So
I'd mark these as optional peer dependencies.

### Not peer dependencies

@elastic/datemath, d3, inter-ui, moment, prop-types, query-string,
react-query, react-router-dom, react-scripts, use-query-params, zod: These
packages are for more specific purposes, and many of them you wouldn't
necessarily need in your app with the current customization possibilities,
and you could use different versions or even other alternatives.

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
  • Loading branch information
peruukki committed Sep 26, 2024
commit 20cff55c1635b8d09471f38f0cf70b103d853f80
21 changes: 9 additions & 12 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,18 @@
"types": "./dist/FeastUI.d.ts",
"module": "./dist/feast-ui.module.js",
"peerDependencies": {
"@elastic/datemath": "^5.0.3",
"@elastic/eui": "^55.0.1",
"@emotion/react": "^11.7.1",
"d3": "^7.3.0",
"inter-ui": "^3.19.3",
"moment": "^2.29.1",
"prop-types": "^15.8.1",
"query-string": "^7.1.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-query": "^3.34.12",
"react-router-dom": "<6.4.0",
"react-scripts": "^5.0.0",
"use-query-params": "^1.2.3",
"zod": "^3.11.6"
"react-dom": "^17.0.2"
},
"peerDependenciesMeta": {
"@elastic/eui": {
"optional": true
},
"@emotion/react": {
"optional": true
}
},
"dependencies": {
"@elastic/datemath": "^5.0.3",
Expand Down