refactor: Use get_any_feature_view in online flow instead of listing them#4545
Merged
franciscojavierarceo merged 2 commits intofeast-dev:masterfrom Sep 20, 2024
Merged
Conversation
Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: tokoko <togurgenidze@gmail.com>
franciscojavierarceo
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently during
get_online_featurescall, feast lists all feature views in the registry, stores them in a dict and then does lookups. This PR changes the flow to directly retrieving only the required feature views.