Skip to content

fix: Adding protobuf<5 as a required dependency due to snowflake limitations #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 4 commits into from
Sep 19, 2024
Merged

fix: Adding protobuf<5 as a required dependency due to snowflake limitations #4537

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa84536
fix: Removed protobuf as a required dependency
Sep 18, 2024
8fae3c3
fix: Removed install-protoc-dependencies target
Sep 18, 2024
048c17c
fix: Ran lock python dependencies to correct dependencies
Sep 18, 2024
b764460
fix: Adding protobuf<5 as a required dependency due to snowflake limi…
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Removed install-protoc-dependencies target 
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
  • Loading branch information
Bhargav Dodla committed Sep 18, 2024
commit 8fae3c3eb9152785f60f2e29bdad265a5d6f22ba
5 changes: 1 addition & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ lock-python-ci-dependencies:
package-protos:
cp -r ${ROOT_DIR}/protos ${ROOT_DIR}/sdk/python/feast/protos

install-protoc-dependencies:
pip install "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"

compile-protos-python: install-protoc-dependencies
compile-protos-python:
python setup.py build_python_protos --inplace

install-python:
Expand Down