Skip to content

feat: Updating FeatureViewProjection and OnDemandFeatureView to add batch_source and entities #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 16 commits into from
Sep 23, 2024
Merged

feat: Updating FeatureViewProjection and OnDemandFeatureView to add batch_source and entities #4530

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b791284
feat: Updating protos for Projections to include more info
franciscojavierarceo Sep 17, 2024
54ca376
adding unit test
franciscojavierarceo Sep 18, 2024
cf613bd
adding type checking where batch source is already serialized into pr…
franciscojavierarceo Sep 18, 2024
44066d2
almost got everything working and type validation behaving
franciscojavierarceo Sep 18, 2024
2837c1c
cleaned up and have tests behaving
franciscojavierarceo Sep 18, 2024
52d4253
removed comment
franciscojavierarceo Sep 18, 2024
34f99b9
updated FeatureViewProjection batch_source serialization
franciscojavierarceo Sep 19, 2024
fcf2917
trying to debug a test
franciscojavierarceo Sep 19, 2024
3c7812b
handling snowflake issue, cant confirm why it is happening so just go…
franciscojavierarceo Sep 19, 2024
6c9a21f
linter
franciscojavierarceo Sep 19, 2024
1103af7
trying to handle it correctly
franciscojavierarceo Sep 19, 2024
987c690
handling the else case for from_feature_view_definition
franciscojavierarceo Sep 19, 2024
c5a7ea3
adding print
franciscojavierarceo Sep 21, 2024
0d489a9
adding test of issue
franciscojavierarceo Sep 21, 2024
a85854e
think i got everything working now
franciscojavierarceo Sep 21, 2024
cf86862
removing print
franciscojavierarceo Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handling snowflake issue, cant confirm why it is happening so just go… 
…ing to put a workaround

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Sep 21, 2024
commit 3c7812be9a78b7c5275ac3f22c2d97370f52db90
5 changes: 2 additions & 3 deletions sdk/python/feast/infra/materialization/snowflake_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,9 @@ def _materialize_one(

fv_latest_values_sql = offline_job.to_sql()

print(f'this is for fja {feature_view}')
print(f'\nthis is for fja 2 {feature_view.entity_columns}')
first_feature_view_entity_name = getattr(feature_view.entity_columns[0], "name", None)
if (
feature_view.entity_columns[0].name == DUMMY_ENTITY_ID
first_feature_view_entity_name == DUMMY_ENTITY_ID
): # entityless Feature View's placeholder entity
entities_to_write = 1
else:
Expand Down