Skip to content

fix: Removed the k8s dependency from required dependencies #4519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 2 commits into from
Sep 17, 2024
Merged

fix: Removed the k8s dependency from required dependencies #4519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cca5d9d
Removed the k8s dependency from required dependencies
redhatHameed Sep 13, 2024
8905b0f
updated requirments lock files
redhatHameed Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed the k8s dependency from required dependencies 
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
  • Loading branch information
@redhatHameed
redhatHameed committed Sep 16, 2024
commit cca5d9dbd76475e5f9e2c3a0fa044c42d6cea588
5 changes: 4 additions & 1 deletion sdk/python/feast/permissions/server/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
AuthManager,
set_auth_manager,
)
from feast.permissions.auth.kubernetes_token_parser import KubernetesTokenParser
from feast.permissions.auth.oidc_token_parser import OidcTokenParser
from feast.permissions.auth.token_extractor import TokenExtractor
from feast.permissions.auth.token_parser import TokenParser
Expand Down Expand Up @@ -116,6 +115,10 @@ def init_auth_manager(
raise ValueError(f"Unmanaged server type {server_type}")

if auth_type == AuthManagerType.KUBERNETES:
from feast.permissions.auth.kubernetes_token_parser import (
KubernetesTokenParser,
)

token_parser = KubernetesTokenParser()
elif auth_type == AuthManagerType.OIDC:
assert isinstance(auth_config, OidcAuthConfig)
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"psutil",
"bigtree>=0.19.2",
"pyjwt",
"kubernetes<=20.13.0",
]

GCP_REQUIRED = [
Expand Down