Skip to content

feat: Return entity key in the retrieval document api #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 27 commits into from
Sep 20, 2024
Merged

feat: Return entity key in the retrieval document api #4511

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
dcb27de
update entity retrieval and add duckdb
HaoXuAI Sep 10, 2024
c24dc75
lint
HaoXuAI Sep 10, 2024
6224ee9
fix lint
HaoXuAI Sep 10, 2024
ad8e4ad
fix lint
HaoXuAI Sep 10, 2024
d5df056
fix lint
HaoXuAI Sep 10, 2024
6e841c2
fix lint
HaoXuAI Sep 10, 2024
2432b7d
fix lint
HaoXuAI Sep 10, 2024
4f5603b
fix lint
HaoXuAI Sep 10, 2024
08039e4
fix lint
HaoXuAI Sep 10, 2024
6162517
fix lint
HaoXuAI Sep 10, 2024
a341071
fix typo
HaoXuAI Sep 10, 2024
4438d05
fix typo
HaoXuAI Sep 10, 2024
36e094b
fix typo
HaoXuAI Sep 10, 2024
4328637
fix typo
HaoXuAI Sep 10, 2024
2d7162c
fix typo
HaoXuAI Sep 10, 2024
a5520f5
fix typo
HaoXuAI Sep 10, 2024
85e329a
fix typo
HaoXuAI Sep 10, 2024
f67d25a
fix typo
HaoXuAI Sep 10, 2024
6b9255d
fix lint
HaoXuAI Sep 10, 2024
23e5438
fix test
HaoXuAI Sep 11, 2024
a649ad1
fix test
HaoXuAI Sep 11, 2024
ca89dcb
fix test
HaoXuAI Sep 11, 2024
90bceff
fix test
HaoXuAI Sep 11, 2024
bfcdcc3
Merge branch 'master' into hao-xu-duckdb-vector
HaoXuAI Sep 19, 2024
fe9cdf0
fix test
HaoXuAI Sep 19, 2024
f9ffb85
fix test
HaoXuAI Sep 19, 2024
3b3fa0e
fix test
HaoXuAI Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo 
Signed-off-by: cmuhao <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Sep 10, 2024
commit 85e329a17f092a53ce128ac1d4c7710b9e1976d9
5 changes: 2 additions & 3 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,7 +1702,7 @@ def _retrieve_from_online_store(
top_k: int,
distance_metric: Optional[str],
) -> List[
Tuple[Timestamp, EntityKey, "FieldStatus.ValueType", Value, Value, Value]
Tuple[Timestamp, Optional[EntityKey], "FieldStatus.ValueType", Value, Value, Value]
]:
"""
Search and return document features from the online document store.
Expand All @@ -1724,8 +1724,7 @@ def _retrieve_from_online_store(
if row_ts is not None:
row_ts_proto.FromDatetime(row_ts)

if entity_key is None or feature_val is None or vector_value is None or distance_val is None:
entity_key = EntityKey()
if feature_val is None or vector_value is None or distance_val is None:
feature_val = Value()
vector_value = Value()
distance_val = Value()
Expand Down