Skip to content

fix: Refactor auth_client_manager_factory.py in function get_auth_client_m… #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Sep 12, 2024
Merged

fix: Refactor auth_client_manager_factory.py in function get_auth_client_m… #4505

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
619f8a8
Refactor auth_client_manager_factory.py in function get_auth_client_m…
tmihalac Sep 9, 2024
3608752
Refactor auth_client_manager_factory.py in function get_auth_client_m…
tmihalac Sep 10, 2024
0a646ef
Refactor auth_client_manager_factory.py in function get_auth_client_m…
tmihalac Sep 10, 2024
83d672e
Refactor auth_client_manager_factory.py in function get_auth_client_m…
tmihalac Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor auth_client_manager_factory.py in function get_auth_client_m… 
…anager

-updated test following review

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
@tmihalac
tmihalac committed Sep 10, 2024
commit 0a646ef7629804bcb458e8bcc3e787e1965614cb
29 changes: 6 additions & 23 deletions sdk/python/tests/unit/permissions/auth/client/test_authentication_client_manager_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@
import assertpy
import jwt
import pytest
import yaml

from feast.permissions.auth.auth_type import AuthType
from feast.permissions.auth_model import (
KubernetesAuthConfig,
NoAuthConfig,
OidcClientAuthConfig,
AuthConfig,
)
from feast.permissions.client.auth_client_manager import (
AuthenticationClientManagerFactory,
Expand All @@ -20,27 +19,11 @@


@mock.patch.dict(os.environ, {"INTRA_COMMUNICATION_BASE64": "server_intra_com_val"})
@pytest.mark.parametrize(
"auth_config",
[
NoAuthConfig(),
KubernetesAuthConfig(**{"type": "kubernetes"}),
OidcClientAuthConfig(
**{
"type": "oidc",
"client_id": "feast-integration-client",
"client_secret": "feast-integration-client-secret",
"username": "reader_writer",
"password": "password",
"auth_discovery_url": "KEYCLOAK_URL_PLACE_HOLDER/realms/master/.well-known/openid-configuration",
}
),
],
)
def test_authentication_client_manager_factory(auth_config):
authentication_client_manager_factory = AuthenticationClientManagerFactory(
auth_config
)
raw_config = yaml.safe_load(auth_config)
auth_config = AuthConfig(type=raw_config["auth"]["type"])

authentication_client_manager_factory = AuthenticationClientManagerFactory(auth_config)

authentication_client_manager = (
authentication_client_manager_factory.get_auth_client_manager()
Expand Down