Skip to content

feat: Faiss and In memory store #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 15 commits into from
Oct 23, 2024
Merged

feat: Faiss and In memory store #4464

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9d5022b
add faiss & in memory online store
HaoXuAI Aug 29, 2024
1f10a72
add faiss & in memory online store
HaoXuAI Aug 29, 2024
ab231a7
add faiss & in memory online store
HaoXuAI Aug 29, 2024
b45ea90
add faiss & in memory online store
HaoXuAI Aug 29, 2024
bc84eb5
add faiss & in memory online store
HaoXuAI Aug 29, 2024
14ffa55
add faiss & in memory online store
HaoXuAI Aug 29, 2024
7d7a1c6
add faiss & in memory online store
HaoXuAI Aug 29, 2024
36ed176
add faiss & in memory online store
HaoXuAI Aug 29, 2024
2d096ba
add faiss & in memory online store
HaoXuAI Aug 29, 2024
05b54c8
add faiss & in memory online store
HaoXuAI Aug 29, 2024
086b02e
add faiss & in memory online store
HaoXuAI Aug 29, 2024
2485e2b
add faiss & in memory online store
HaoXuAI Aug 29, 2024
2a2d6f5
Merge branch 'master' into hao-xu-faiss-and-inmemdb
HaoXuAI Sep 6, 2024
a109184
add dependency
HaoXuAI Sep 6, 2024
44763db
update package name
HaoXuAI Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add faiss & in memory online store 
Signed-off-by: cmuhao <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Aug 29, 2024
commit 7d7a1c6320338dbd4dbbbfa34f54615843684b1a
19 changes: 10 additions & 9 deletions sdk/python/feast/infra/online_stores/contrib/faiss_online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from feast.protos.feast.types.EntityKey_pb2 import EntityKey
from feast.protos.feast.types.Value_pb2 import Value
from feast.repo_config import FeastConfigBaseModel
from feast.infra.key_encoding_utils import serialize_entity_key, deserialize_entity_key


class FaissOnlineStoreConfig(FeastConfigBaseModel):
Expand Down Expand Up @@ -99,10 +100,10 @@ def online_read(
if self._index is None:
return [(None, None)] * len(entity_keys)

results: List[Tuple[Optional[datetime], Optional[Dict[str, Value]]]] = []
results = []
for entity_key in entity_keys:
entity_key_tuple = tuple(entity_key.name, entity_key.join_keys)
idx = self._in_memory_store.entity_keys.get(entity_key_tuple, -1)
serialized_key = serialize_entity_key(entity_key, entity_key_serialization_version=2)
idx = self._in_memory_store.entity_keys.get(serialized_key, -1)
if idx == -1:
results.append((None, None))
else:
Expand All @@ -128,10 +129,10 @@ def online_write_batch(
return

feature_vectors = []
entity_key_tuples = []
serialized_keys = []

for entity_key, feature_dict, _, _ in data:
entity_key_tuple = (entity_key.name, entity_key.join_keys)
serialized_key = serialize_entity_key(entity_key, entity_key_serialization_version=2)
feature_vector = np.array(
[
feature_dict[name].double_val
Expand All @@ -141,12 +142,12 @@ def online_write_batch(
)

feature_vectors.append(feature_vector)
entity_key_tuples.append(entity_key_tuple)
serialized_keys.append(serialized_key)

feature_vectors_array = np.array(feature_vectors)

existing_indices = [
self._in_memory_store.entity_keys.get(ekt, -1) for ekt in entity_key_tuples
self._in_memory_store.entity_keys.get(sk, -1) for sk in serialized_keys
]
mask = np.array(existing_indices) != -1
if np.any(mask):
Expand All @@ -159,8 +160,8 @@ def online_write_batch(
)
self._index.add(feature_vectors_array)

for ekt, idx in zip(entity_key_tuples, new_indices):
self._in_memory_store.entity_keys[ekt] = idx
for sk, idx in zip(serialized_keys, new_indices):
self._in_memory_store.entity_keys[sk] = idx

if progress:
progress(len(data))
Expand Down