Skip to content

fix: Initial commit targetting grpc registry server #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 10 commits into from
Aug 30, 2024
Merged

fix: Initial commit targetting grpc registry server #4458

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3e07339
initial commit targetting grpc registry server
dmartinol Aug 28, 2024
e833ff1
refactor: Introduced base class FeastError for all Feast exceptions (…
dmartinol Aug 29, 2024
d94c9ac
initial commit targetting grpc registry server
dmartinol Aug 28, 2024
acd9763
fixed merge error
dmartinol Aug 29, 2024
592c1ce
initial commit targetting grpc registry server
dmartinol Aug 28, 2024
73070ca
fixed merge error
dmartinol Aug 29, 2024
24661df
integrated comment
dmartinol Aug 29, 2024
400615a
Merge branch 'master' into issue-4392
dmartinol Aug 29, 2024
618cb00
Merge branch 'feast-dev:master' into issue-4392
dmartinol Aug 30, 2024
50306c1
moved imports as per comment
dmartinol Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
integrated comment 
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
  • Loading branch information
@dmartinol
dmartinol committed Aug 29, 2024
commit 24661dfdbe677d99d123507b1a3e541535b7fae9
6 changes: 3 additions & 3 deletions sdk/python/feast/registry_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ def start_server(store: FeatureStore, port: int, wait_for_termination: bool = Tr

server = grpc.server(
futures.ThreadPoolExecutor(max_workers=10),
interceptors=grpc_interceptors(auth_manager_type),
interceptors=_grpc_interceptors(auth_manager_type),
)
RegistryServer_pb2_grpc.add_RegistryServerServicer_to_server(
RegistryServer(store.registry), server
Expand All @@ -672,11 +672,11 @@ def start_server(store: FeatureStore, port: int, wait_for_termination: bool = Tr
return server


def grpc_interceptors(
def _grpc_interceptors(
auth_type: AuthManagerType,
) -> Optional[list[grpc.ServerInterceptor]]:
"""
A list of the authorization interceptors.
A list of the interceptors for the registry server.

Args:
auth_type: The type of authorization manager, from the feature store configuration.
Expand Down