Skip to content

feat: Add registry methods for dealing with all FV types #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 6 commits into from
Sep 6, 2024
Merged

feat: Add registry methods for dealing with all FV types #4435

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f9dfb5
add new registry method for working with any fv type
tokoko Aug 22, 2024
9b84ce7
fix: different project for each test in test_universal_registry
tokoko Aug 24, 2024
c7b6b6f
Merge branch 'master' into extend-get-feature-view-2
tokoko Sep 6, 2024
b365afc
revert project names to project in test_universal_registry
tokoko Sep 6, 2024
48cf968
remove print statements from test_universal_registry
tokoko Sep 6, 2024
f55ff4b
Merge branch 'master' into extend-get-feature-view-2
tokoko Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert project names to project in test_universal_registry 
Signed-off-by: tokoko <togurgenidze@gmail.com>
  • Loading branch information
@tokoko
tokoko committed Sep 6, 2024
commit b365afc4ef2c9a679f0d9574fb3a1674a913b635
26 changes: 13 additions & 13 deletions sdk/python/tests/integration/registration/test_universal_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def test_apply_entity_success(test_registry):
tags={"team": "matchmaking"},
)

project = "test_apply_entity_success"
project = "project"

# Register Entity
test_registry.apply_entity(entity, project)
Expand Down Expand Up @@ -464,7 +464,7 @@ def test_apply_feature_view_success(test_registry: BaseRegistry):
ttl=timedelta(minutes=5),
)

project = "test_apply_feature_view_success"
project = "project"

# Register Feature View
test_registry.apply_feature_view(fv1, project)
Expand Down Expand Up @@ -565,7 +565,7 @@ def location_features_from_push(inputs: pd.DataFrame) -> pd.DataFrame:
df["first_char"] = inputs["string_feature"].str[:1].astype("string")
return df

project = "test_apply_on_demand_feature_view_success"
project = "project"

with pytest.raises(FeatureViewNotFoundException):
test_registry.get_user_metadata(project, location_features_from_push)
Expand Down Expand Up @@ -646,7 +646,7 @@ def test_apply_data_source(test_registry):
ttl=timedelta(minutes=5),
)

project = "test_apply_data_source"
project = "project"

# Register data source and feature view
test_registry.apply_data_source(batch_source, project, commit=False)
Expand Down Expand Up @@ -765,7 +765,7 @@ def simple_udf(x: int):
tags={},
)

project = "test_modify_feature_views_success"
project = "project"

# Register Feature Views
test_registry.apply_feature_view(odfv1, project, False)
Expand Down Expand Up @@ -1013,7 +1013,7 @@ def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
)
def test_update_infra(test_registry):
# Create infra object
project = "test_update_infra"
project = "project"
infra = test_registry.get_infra(project=project)

assert len(infra.infra_objects) == 0
Expand Down Expand Up @@ -1070,7 +1070,7 @@ def test_registry_cache(test_registry):
ttl=timedelta(minutes=5),
)

project = "test_registry_cache"
project = "project"

# Register data source and feature view
test_registry.apply_data_source(batch_source, project)
Expand Down Expand Up @@ -1117,7 +1117,7 @@ def test_registry_cache_thread_async(test_registry):
created_timestamp_column="timestamp",
)

project = "test_registry_cache_thread_async"
project = "project"

# Register data source
test_registry.apply_data_source(batch_source, project)
Expand Down Expand Up @@ -1189,7 +1189,7 @@ def simple_udf(x: int):
tags={"team": "matchmaking"},
)

project = "test_apply_stream_feature_view_success"
project = "project"

# Register Stream Feature View
test_registry.apply_feature_view(sfv, project)
Expand Down Expand Up @@ -1237,7 +1237,7 @@ def test_apply_feature_service_success(test_registry):
fs = FeatureService(
name="my_feature_service_1", features=[feature_view[["feature1", "feature2"]]]
)
project = "test_apply_feature_service_success"
project = "project"

# Register Feature Service
test_registry.apply_feature_service(fs, project)
Expand Down Expand Up @@ -1276,7 +1276,7 @@ def test_modify_feature_service_success(test_registry):
fs = FeatureService(
name="my_feature_service_1", features=[feature_view[["feature1", "feature2"]]]
)
project = "test_modify_feature_service_success"
project = "project"

# Register Feature service
test_registry.apply_feature_service(fs, project)
Expand Down Expand Up @@ -1323,7 +1323,7 @@ def test_commit():
tags={"team": "matchmaking"},
)

project = "test_commit"
project = "project"

# Register Entity without commiting
test_registry.apply_entity(entity, project, commit=False)
Expand Down Expand Up @@ -1420,7 +1420,7 @@ def test_apply_permission_success(test_registry):
types=FeatureView,
)

project = "test_apply_permission_success"
project = "project"

# Register Permission
test_registry.apply_permission(permission, project)
Expand Down