Skip to content

fix: Using repo_config parameter in teardown to allow for feature-store-yaml overrides #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 3 commits into from
Aug 16, 2024
Merged

fix: Using repo_config parameter in teardown to allow for feature-store-yaml overrides #4413

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7311e3
fix: using repo_config parameter in teardown to allow for feature-sto…
danbaron63 Aug 15, 2024
9364582
fix: fixing linting and formatting issues in tests
danbaron63 Aug 15, 2024
7b2dd08
fix: removing unnecessary Path object construction
danbaron63 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: removing unnecessary Path object construction 
Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
  • Loading branch information
@danbaron63
danbaron63 committed Aug 15, 2024
commit 7b2dd08a0467a04583c1efe2b2b26a887c1b24e6
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ def setup(self, registry: RegistryConfig):
repo_path = Path(tempfile.mkdtemp())
with open(repo_path / "feature_store.yaml", "w") as outfile:
yaml.dump(config.model_dump(by_alias=True), outfile)
repo_path = Path(str(repo_path.resolve()))
repo_path = repo_path.resolve()

self.server_port = free_port()
host = "0.0.0.0"
Expand Down