Skip to content

feat: Allow feast snowflake to read in byte string for private-key authentication #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 8 commits into from
Aug 13, 2024
Merged

feat: Allow feast snowflake to read in byte string for private-key authentication #4384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be3ecb2
allow feast snowflake to read in byte string for private-key authenti…
arturkolakowski Aug 5, 2024
a9eac3e
Update type hint for to use Union instead of | syntax
arturkolakowski Aug 8, 2024
625d2a6
Update type hint for private_key to use Union instead of | syntax
arturkolakowski Aug 8, 2024
f486384
Update type hint in parse_private_key_path
arturkolakowski Aug 8, 2024
636089f
added private_key_content in Snowflake configs to support key-pair au…
arturkolakowski Aug 12, 2024
fb175df
fix incompatible linting types
arturkolakowski Aug 12, 2024
8553472
remove unused Union import
arturkolakowski Aug 12, 2024
af277a4
fix formating
arturkolakowski Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
allow feast snowflake to read in byte string for private-key authenti… 
…cation

Signed-off-by: Artur <artur.kolakowski@medely.com>
  • Loading branch information
@arturkolakowski
arturkolakowski committed Aug 5, 2024
commit be3ecb2e324fe7122c75d5eb5ffb40e5bd91b878
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/materialization/snowflake_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ class SnowflakeMaterializationEngineConfig(FeastConfigBaseModel):
authenticator: Optional[str] = None
""" Snowflake authenticator name """

private_key: Optional[str] = None
""" Snowflake private key file path"""
private_key: Optional[str | bytes] = None
""" Snowflake private key stored as bytes or file path"""

private_key_passphrase: Optional[str] = None
""" Snowflake private key file passphrase"""
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel):
authenticator: Optional[str] = None
""" Snowflake authenticator name """

private_key: Optional[str] = None
""" Snowflake private key file path"""
private_key: Optional[str | bytes] = None
""" Snowflake private key stored as bytes or file path"""

private_key_passphrase: Optional[str] = None
""" Snowflake private key file passphrase"""
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/online_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ class SnowflakeOnlineStoreConfig(FeastConfigBaseModel):
authenticator: Optional[str] = None
""" Snowflake authenticator name """

private_key: Optional[str] = None
""" Snowflake private key file path"""
private_key: Optional[str | bytes] = None
""" Snowflake private key stored as bytes or file path"""

private_key_passphrase: Optional[str] = None
""" Snowflake private key file passphrase"""
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/registry/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ class SnowflakeRegistryConfig(RegistryConfig):
authenticator: Optional[str] = None
""" Snowflake authenticator name """

private_key: Optional[str] = None
""" Snowflake private key file path"""
private_key: Optional[str | bytes] = None
""" Snowflake private key stored as bytes or file path"""

private_key_passphrase: Optional[str] = None
""" Snowflake private key file passphrase"""
Expand Down
20 changes: 16 additions & 4 deletions sdk/python/feast/infra/utils/snowflake/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from logging import getLogger
from pathlib import Path
from tempfile import TemporaryDirectory
from typing import Any, Dict, Iterator, List, Optional, Tuple, cast
from typing import Any, Dict, Iterator, List, Optional, Tuple, Union, cast

import pandas as pd
import pyarrow
Expand Down Expand Up @@ -510,13 +510,25 @@ def chunk_helper(lst: pd.DataFrame, n: int) -> Iterator[Tuple[int, pd.DataFrame]
yield int(i / n), lst[i : i + n]


def parse_private_key_path(key_path: str, private_key_passphrase: str) -> bytes:
with open(key_path, "rb") as key:
def parse_private_key_path(
private_key: Union[bytes | str], private_key_passphrase: str
) -> bytes:
"""Returns snowflake pkb by parsing and reading either from private key path or as byte string."""
if isinstance(private_key, str):
with open(private_key, "rb") as key:
p_key = serialization.load_pem_private_key(
key.read(),
password=private_key_passphrase.encode(),
backend=default_backend(),
)
elif isinstance(private_key, bytes):
p_key = serialization.load_pem_private_key(
key.read(),
private_key,
password=private_key_passphrase.encode(),
backend=default_backend(),
)
else:
raise ValueError("private_key must be either type of str or bytes.")

pkb = p_key.private_bytes(
encoding=serialization.Encoding.DER,
Expand Down