Skip to content

feat: Add async feature retrieval for Postgres Online Store #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Jul 8, 2024
Merged

feat: Add async feature retrieval for Postgres Online Store #4327

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8072ed
Add async retrieval for postgres
TomSteenbergen Jul 2, 2024
1d5719a
Format
TomSteenbergen Jul 2, 2024
84594f7
Update _prepare_keys method
TomSteenbergen Jul 2, 2024
ac297ca
Fix typo
TomSteenbergen Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo 
Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com>
  • Loading branch information
@TomSteenbergen
TomSteenbergen committed Jul 2, 2024
commit ac297ca827ae7d8463d0c837258e81728f38f2ef
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def _construct_query_and_params(

@staticmethod
def _prepare_keys(
Copy link
Copy Markdown
Contributor Author

@TomSteenbergen TomSteenbergen Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new logic, just moved to a separate method so it can be re-used.

entity_keys: List[EntityKeyProto], entity_key_seriaization_version: int
entity_keys: List[EntityKeyProto], entity_key_serialization_version: int
) -> List[bytes]:
"""Prepare all keys in a list to make fewer round trips to the database."""
return [
Expand Down