Skip to content

feat: Move get_online_features to OnlineStore interface #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 3 commits into from
Jul 1, 2024
Merged

feat: Move get_online_features to OnlineStore interface #4319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ffcaf3
move get_online_features to OnlineStore interface
tokoko Jun 27, 2024
d03f369
fix pydantic warnings
tokoko Jun 27, 2024
8f24355
run ruff format
tokoko Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix pydantic warnings 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
@tokoko
tokoko committed Jun 27, 2024
commit d03f3699526f54b8b69c1da01eb2070c87ad2478
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/materialization/kubernetes/k8s_materialization_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def _create_kubernetes_job(self, job_id, paths, feature_view):
def _create_configuration_map(self, job_id, paths, feature_view, namespace):
"""Create a Kubernetes configmap for this job"""

feature_store_configuration = yaml.dump(self.repo_config.dict(by_alias=True))
feature_store_configuration = yaml.dump(self.repo_config.model_dump(by_alias=True))

materialization_config = yaml.dump(
{"paths": paths, "feature_view": feature_view.name}
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def setup(self, registry: RegistryConfig):

repo_path = Path(tempfile.mkdtemp())
with open(repo_path / "feature_store.yaml", "w") as outfile:
yaml.dump(config.dict(by_alias=True), outfile)
yaml.dump(config.model_dump(by_alias=True), outfile)
repo_path = str(repo_path.resolve())

self.server_port = free_port()
Expand Down