Skip to content

feat: Bump psycopg2 to psycopg3 for all Postgres components #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 21 commits into from
Jul 1, 2024
Merged

feat: Bump psycopg2 to psycopg3 for all Postgres components #4303

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9cdceab
Makefile: Formatting
job-almekinders Jun 19, 2024
dca9c9a
Makefile: Exclude Snowflake tests for postgres offline store tests
job-almekinders Jun 19, 2024
fc65cfc
Bootstrap: Use conninfo
job-almekinders Jun 19, 2024
a3ea80d
Tests: Make connection string compatible with psycopg3
job-almekinders Jun 19, 2024
e53d9e6
Tests: Test connection type pool and singleton
job-almekinders Jun 20, 2024
59cbd10
Global: Replace conn.set_session() calls to be psycopg3 compatible
job-almekinders Jun 20, 2024
0f86e9e
Offline: Use psycopg3
job-almekinders Jun 19, 2024
cd91fdc
Online: Use psycopg3
job-almekinders Jun 19, 2024
3504c77
Online: Restructure online_write_batch
job-almekinders Jun 20, 2024
6e45f8e
Online: Use correct placeholder
job-almekinders Jun 20, 2024
c755fcd
Online: Handle bytes properly in online_read()
job-almekinders Jun 20, 2024
acd4a8f
Online: Whitespace
job-almekinders Jun 20, 2024
36147ef
Online: Open ConnectionPool
job-almekinders Jun 21, 2024
d3fd7e7
Online: Add typehint
job-almekinders Jun 21, 2024
0a9bced
Utils: Use psycopg3
job-almekinders Jun 19, 2024
af136da
Lint: Raise exceptions if cursor returned no columns or rows
job-almekinders Jun 21, 2024
0926a15
Add comment on +psycopg string
job-almekinders Jun 21, 2024
6514987
Docs: Remove mention of psycopg2
job-almekinders Jun 21, 2024
915454c
Lint: Fix
job-almekinders Jun 21, 2024
d8e6619
Default to postgresql+psycopg and log warning
job-almekinders Jun 25, 2024
3328530
Solve merge conflicts
job-almekinders Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Makefile: Formatting 
Signed-off-by: Job Almekinders <job.almekinders@teampicnic.com>
  • Loading branch information
@job-almekinders
job-almekinders committed Jun 27, 2024
commit 9cdceab7e7fd5bb9a40d42aa39d88fc2948e5ae8
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ install-python:
python setup.py develop

lock-python-dependencies:
uv pip compile --system --no-strip-extras setup.py --output-file sdk/python/requirements/py$(PYTHON)-requirements.txt
uv pip compile --system --no-strip-extras setup.py --output-file sdk/python/requirements/py$(PYTHON)-requirements.txt

lock-python-dependencies-all:
pixi run --environment py39 --manifest-path infra/scripts/pixi/pixi.toml "uv pip compile --system --no-strip-extras setup.py --output-file sdk/python/requirements/py3.9-requirements.txt"
Expand Down Expand Up @@ -164,7 +164,7 @@ test-python-universal-mssql:
sdk/python/tests


# To use Athena as an offline store, you need to create an Athena database and an S3 bucket on AWS.
# To use Athena as an offline store, you need to create an Athena database and an S3 bucket on AWS.
# https://docs.aws.amazon.com/athena/latest/ug/getting-started.html
# Modify environment variables ATHENA_REGION, ATHENA_DATA_SOURCE, ATHENA_DATABASE, ATHENA_WORKGROUP or
# ATHENA_S3_BUCKET_NAME according to your needs. If tests fail with the pytest -n 8 option, change the number to 1.
Expand All @@ -191,7 +191,7 @@ test-python-universal-athena:
not s3_registry and \
not test_snowflake" \
sdk/python/tests

test-python-universal-postgres-offline:
PYTHONPATH='.' \
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.offline_stores.contrib.postgres_repo_configuration \
Expand Down