chore: Remove serverless feature server deployments#4272
Merged
franciscojavierarceo merged 4 commits intoJun 19, 2024
Conversation
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Collaborator
|
Do you think it's possible to change it to a plugin instead of removing it? Or is it not worth to di it? |
Collaborator
Author
|
I don't think it's worth it, not sure how would one do that even if it was (maybe with Infras). In any case, I don't think there's anyone around willing to maintain that. |
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Collaborator
Author
|
@HaoXuAI Can we move ahead here? The code can be always dug up if anyone decides to support something like this as some sort of a plugin. |
Member
|
I haven't reviewed the code thoroughly but I am assuming this won't be backwards compatible and it will be a breaking change, yeah? |
Collaborator
Author
|
The issue has been up for a few weeks and I posted on slack as well. We can deprecate first and remove later if you think that's necessary. |
franciscojavierarceo
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes serverless feature server deployment options (aws lambda, gcp cloudrun)
Which issue(s) this PR fixes:
Fixes #4236