Skip to content

feat: Remote offline Store #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 41 commits into from
Jun 13, 2024
Merged

feat: Remote offline Store #4262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
47a9cfb
feat: Added offline store remote deployment functionly using arrow fl…
redhatHameed May 7, 2024
088d739
Initial functional commit for remote get_historical_features
dmartinol May 9, 2024
241fe50
remote offline store example
dmartinol May 9, 2024
e276704
removing unneeded test code and fixinf impotrts
dmartinol May 9, 2024
cdd8a4e
call do_put only once, postpone the invocation of do_put and simplifi…
dmartinol May 10, 2024
54f6061
added primitive parameters to the command descriptor
dmartinol May 10, 2024
be91d23
removed redundant param
dmartinol May 13, 2024
f074044
Initial skeleton of unit test for offline server
dmartinol May 15, 2024
06fe80d
added unit test for offline store remote client
redhatHameed May 14, 2024
49857da
testing all offlinestore APIs
dmartinol May 17, 2024
a30c666
integrated comments
dmartinol May 17, 2024
2c8d677
Updated remote offline server readme with the capability to init with…
tmihalac May 17, 2024
1bca528
added RemoteOfflineStoreDataSourceCreator,
dmartinol May 27, 2024
f035430
added missing CI requirement
dmartinol May 27, 2024
632a4c0
fixed linter
dmartinol May 27, 2024
94f927b
fixed multiprocess CI requirement
dmartinol May 27, 2024
36b3479
feat: Added offline store remote deployment functionly using arrow fl…
redhatHameed May 7, 2024
799ae07
fix test errors
dmartinol May 29, 2024
3029881
managing feature view aliases and restored skipped tests
dmartinol May 29, 2024
f6c481b
fixced linter issue
dmartinol May 29, 2024
871e5d4
fixed broken test
dmartinol May 29, 2024
ddc3600
added supported deployment modes using helm chart for online (defaul…
redhatHameed May 22, 2024
9a34251
updated the document for offline remote server
redhatHameed Jun 4, 2024
efeeeae
added the document for remote offline server
redhatHameed Jun 4, 2024
7077bee
rebase and fix conflicts
redhatHameed Jun 6, 2024
5697056
feat: Added offline store remote deployment functionly using arrow fl…
redhatHameed May 7, 2024
f9ca13b
added unit test for offline store remote client
redhatHameed May 14, 2024
46fa3d5
added RemoteOfflineStoreDataSourceCreator,
dmartinol May 27, 2024
b36105a
feat: Added offline store remote deployment functionly using arrow fl…
redhatHameed May 7, 2024
2f4a5ba
Added missing remote offline store apis implementation
tmihalac Jun 4, 2024
52b0156
Fixed tests
tmihalac Jun 5, 2024
32600fc
Implemented PR change proposal
tmihalac Jun 6, 2024
d2e012c
Implemented PR change proposal
tmihalac Jun 6, 2024
301021f
updated example readme file
redhatHameed Jun 7, 2024
e34b070
Implemented PR change proposal
tmihalac Jun 10, 2024
dec05c9
fixing the integration tests
redhatHameed Jun 11, 2024
143ef18
Fixed OfflineServer teardown
tmihalac Jun 10, 2024
bd9cd79
updated the document for remote offline feature server and client
redhatHameed Jun 13, 2024
bdf0150
Merge pull request #15 from redhatHameed/doc-change
redhatHameed Jun 13, 2024
17c7e72
Implemented PR change proposal
tmihalac Jun 13, 2024
11a3dae
Merge pull request #16 from tmihalac/implement-remaining-offline-methods
tmihalac Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase and fix conflicts 
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
  • Loading branch information
@redhatHameed
redhatHameed committed Jun 10, 2024
commit 7077beea04ca46772aae0182e3d32e0ece5dea3a
2 changes: 0 additions & 2 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2569,14 +2569,12 @@ def serve_registry(self, port: int) -> None:

registry_server.start_server(self, port)


def serve_offline(self, host: str, port: int) -> None:
"""Start offline server locally on a given port."""
from feast import offline_server

offline_server.start_server(self, host, port)


def serve_transformations(self, port: int) -> None:
"""Start the feature transformation server locally on a given port."""
warnings.warn(
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/requirements/py3.10-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,8 @@ multidict==6.0.5
# yarl
multipledispatch==1.0.0
# via ibis-framework
multiprocess==0.70.16
# via feast (setup.py)
mypy==1.10.0
# via
# feast (setup.py)
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/requirements/py3.11-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ multidict==6.0.5
# yarl
multipledispatch==1.0.0
# via ibis-framework
multiprocess==0.70.16
# via feast (setup.py)
mypy==1.10.0
# via
# feast (setup.py)
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/requirements/py3.9-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,8 @@ multidict==6.0.5
# yarl
multipledispatch==1.0.0
# via ibis-framework
multiprocess==0.70.16
# via feast (setup.py)
mypy==1.10.0
# via
# feast (setup.py)
Expand Down