Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
a9be27d
feat: Adding vector search for sqlite
franciscojavierarceo May 5, 2024
2addd45
adding the sqlite_vss dependency
franciscojavierarceo May 5, 2024
4f9070b
linter
franciscojavierarceo May 6, 2024
7599770
latest progress
franciscojavierarceo May 9, 2024
3f9c0b5
uploading latest progress
franciscojavierarceo May 15, 2024
4f1d01b
updated function
franciscojavierarceo May 15, 2024
2a33c69
adding configuration
franciscojavierarceo May 16, 2024
81e4a27
adding current progress
franciscojavierarceo May 16, 2024
ee300d9
updating requirements files
franciscojavierarceo May 17, 2024
995a9c3
moving to sqlite-vec
franciscojavierarceo May 19, 2024
ceb7395
updating sqlite.py
franciscojavierarceo May 19, 2024
2cf4020
checking in progress
franciscojavierarceo May 20, 2024
494e12f
updated test type
franciscojavierarceo May 20, 2024
714b9c7
got the initialization working, nice
franciscojavierarceo May 22, 2024
cd41bf0
checking in progress from last night
franciscojavierarceo May 22, 2024
ae40c81
removing unnecessary stuff
franciscojavierarceo May 23, 2024
dd5b7e9
fixing merge conflicts
franciscojavierarceo May 27, 2024
59e8b40
removing files changed accidentally]
franciscojavierarceo May 27, 2024
642b68e
uploading current progress...things run but need to update the virtua…
franciscojavierarceo May 28, 2024
2a3dfd2
linted
franciscojavierarceo May 28, 2024
345526b
adding working notes
franciscojavierarceo May 28, 2024
4872d2d
found a bug, original feature_store.py was only grabbing first featur…
franciscojavierarceo May 28, 2024
5f8ff90
cant use a string have to verify it is a proper FeatureView object
franciscojavierarceo May 29, 2024
2a98513
updated got it working, need to fix some other stuff still
franciscojavierarceo May 30, 2024
1db8446
working
franciscojavierarceo May 31, 2024
d48ce6d
linter
franciscojavierarceo May 31, 2024
3fd1979
fixing some type issues
franciscojavierarceo May 31, 2024
773e581
fixed typing and lint issues
franciscojavierarceo May 31, 2024
9716f3c
Merge branch 'master' into get-online-documents-tests
franciscojavierarceo May 31, 2024
ccf5277
updated dependencies
franciscojavierarceo May 31, 2024
4b55f38
fix for pixi and updating requirements
franciscojavierarceo May 31, 2024
c0fcb06
fixed type
franciscojavierarceo May 31, 2024
34e4d29
linter
franciscojavierarceo May 31, 2024
21bbb7d
testing sqlite_vec import
franciscojavierarceo Jun 1, 2024
482df7e
adding minimal example test
franciscojavierarceo Jun 1, 2024
1d8601f
lint
franciscojavierarceo Jun 1, 2024
75b04c1
testing raw sqlite
franciscojavierarceo Jun 2, 2024
13da55d
Printing package version
franciscojavierarceo Jun 2, 2024
1b9a3bb
printing version
franciscojavierarceo Jun 3, 2024
2eedda8
updated requirements
franciscojavierarceo Jun 3, 2024
2d43200
Merge branch 'master' into get-online-documents-tests
franciscojavierarceo Jun 8, 2024
bc90a1c
rebuilding requirments
franciscojavierarceo Jun 8, 2024
c50f1d2
only going to run this on 3.10 for now
franciscojavierarceo Jun 8, 2024
c4eafab
updated docs for sqlite caveats
franciscojavierarceo Jun 8, 2024
eb37121
adding reason
franciscojavierarceo Jun 8, 2024
cfd7611
skipping
franciscojavierarceo Jun 8, 2024
58d595a
updated tests
franciscojavierarceo Jun 8, 2024
8db355c
removing print
franciscojavierarceo Jun 9, 2024
9335fa5
added method call
franciscojavierarceo Jun 10, 2024
511291a
added prubt
franciscojavierarceo Jun 10, 2024
b544527
added print
franciscojavierarceo Jun 10, 2024
efad816
removing print
franciscojavierarceo Jun 10, 2024
436b89a
adding check in sqlite
franciscojavierarceo Jun 10, 2024
263ec43
missed an =
franciscojavierarceo Jun 10, 2024
908b7f3
still running on 3.11
franciscojavierarceo Jun 10, 2024
65952db
typo
franciscojavierarceo Jun 10, 2024
39493b7
fix
franciscojavierarceo Jun 10, 2024
834e4f6
fix
franciscojavierarceo Jun 10, 2024
1c14c97
updated setup and docs
franciscojavierarceo Jun 10, 2024
ec60ea3
renamed things
franciscojavierarceo Jun 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linted
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
franciscojavierarceo committed May 28, 2024
commit 2a3dfd25739d38096143c8a1090b0ec082ec66a8
8 changes: 4 additions & 4 deletions sdk/python/feast/infra/online_stores/sqlite.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import itertools
import json
import os
import sqlite3
import struct
Expand All @@ -32,7 +31,8 @@
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.protos.feast.core.SqliteTable_pb2 import SqliteTable as SqliteTableProto
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto, FloatList as FloatListProto
from feast.protos.feast.types.Value_pb2 import FloatList as FloatListProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto
from feast.repo_config import FeastConfigBaseModel, RepoConfig
from feast.utils import to_naive_utc

Expand Down Expand Up @@ -328,15 +328,15 @@ def retrieve_online_documents(
""")

cur.execute(
f"""
"""
INSERT INTO vec_example(rowid, vector_value)
VALUES (?, ?)
""",
(0, query_embedding_bin)
)

cur.execute(
f"""
"""
select
rowid as entity_key,
null as value,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/example_repos/example_feature_repo_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from feast import Entity, FeatureService, FeatureView, Field, FileSource, PushSource
from feast.on_demand_feature_view import on_demand_feature_view
from feast.types import Float32, Int64, String, Array
from feast.types import Array, Float32, Int64, String

# Note that file source paths are not validated, so there doesn't actually need to be any data
# at the paths for these file sources. Since these paths are effectively fake, this example
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/unit/online_store/test_online_retrieval.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@

import numpy as np
import pandas as pd
import numpy as np
import pytest
from pandas.testing import assert_frame_equal

from feast import FeatureStore, RepoConfig
from feast.errors import FeatureViewNotFoundException
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto, FloatList
from feast.protos.feast.types.Value_pb2 import FloatList
from feast.protos.feast.types.Value_pb2 import Value as ValueProto
from feast.repo_config import RegistryConfig
from tests.utils.cli_repo_creator import CliRunner, get_example_repo

Expand Down