Skip to content

feat: Enable other distance metrics for Vector DB and Update docs #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 8 commits into from
May 7, 2024
Merged

feat: Enable other distance metrics for Vector DB and Update docs #4170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0032969
updated PGVector docs
franciscojavierarceo May 2, 2024
e242a93
adding distance metric to arguments and defaulting to L2
franciscojavierarceo May 2, 2024
6dd845d
linter
franciscojavierarceo May 2, 2024
d192c88
testing other distance metric
franciscojavierarceo May 2, 2024
3b9b3da
updated default
franciscojavierarceo May 2, 2024
cf840c3
linter
franciscojavierarceo May 2, 2024
ee3448f
fixed some copy
franciscojavierarceo May 2, 2024
1d88b01
updated
franciscojavierarceo May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed May 2, 2024
commit 6dd845dfbabe21b053e19b75cb0c839aac597d84
4 changes: 2 additions & 2 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,15 +1757,15 @@ def retrieve_online_documents(
feature=feature,
query=query,
top_k=top_k,
distance_metric=distinct_metric,
distance_metric=distance_metric,
)

def _retrieve_online_documents(
self,
feature: str,
query: Union[str, List[float]],
top_k: int,
distance_metric: str="L2",
distance_metric: str = "L2",
):
if isinstance(query, str):
raise ValueError(
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
from feast.repo_config import RepoConfig
from feast.usage import log_exceptions_and_usage



SUPPORTED_DISTANCE_METRICS_DICT = {
Copy link
Copy Markdown
Collaborator

@HaoXuAI HaoXuAI May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cool!

"L2": "<->",
"inner_product": "<#>",
Expand Down
7 changes: 6 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,12 @@ def retrieve_online_documents(
result = []
if self.online_store:
result = self.online_store.retrieve_online_documents(
config, table, requested_feature, query, top_k, distance_metric,
config,
table,
requested_feature,
query,
top_k,
distance_metric,
)
return result

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def retrieve_online_documents(
requested_feature: str,
query: List[float],
top_k: int,
distance_metric: str="euclidean",
distance_metric: str = "euclidean",
Comment thread
franciscojavierarceo marked this conversation as resolved.
Outdated
) -> List[
Tuple[
Optional[datetime],
Expand Down