Skip to content

fix: Default value is not set in Redis connection string using environment variable #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 1 commit into from
Apr 25, 2024
Merged

fix: Default value is not set in Redis connection string using environment variable #4136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Default value is not set in Redis connection string using enviro… 
…nment variable

Removed documentation of Redis connection string supporting default values when using environment variables as it isn't supported

Fixes #3669

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
@tmihalac
tmihalac committed Apr 23, 2024
commit 21d103995ffa8e3150012d9ad18fcd8d32191ce9
11 changes: 0 additions & 11 deletions docs/how-to-guides/running-feast-in-production.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,17 +257,6 @@ online_store:
connection_string: ${REDIS_CONNECTION_STRING}
```

It is possible to set a default value if the environment variable is not set, with `${ENV_VAR:"default"}`. For instance:

```yaml
project: my_project
registry: data/registry.db
provider: local
online_store:
type: redis
connection_string: ${REDIS_CONNECTION_STRING:"0.0.0.0:6379"}
```

***

## Summary
Expand Down