Skip to content

chore: Drop dependency on non-standard importlib libraries - #4109

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
tokoko:drop-custom-importlib
Apr 19, 2024
Merged

chore: Drop dependency on non-standard importlib libraries#4109
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
tokoko:drop-custom-importlib

Conversation

@tokoko

@tokoko tokoko commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Explicit dependency on non-standard importlib libraries (importlib-resources and importlib_metadata) is no longer required after dropping 3.8. This PR switches to use alternatives from standard library.

Signed-off-by: tokoko <togurg14@freeuni.edu.ge>

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo
franciscojavierarceo merged commit 2c4a347 into feast-dev:master Apr 19, 2024
@tokoko
tokoko deleted the drop-custom-importlib branch April 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants