Skip to content

feat: Make arrow primary interchange for offline ODFV execution #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 2 commits into from
Apr 15, 2024
Merged

feat: Make arrow primary interchange for offline ODFV execution #4083

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1feaa
feat: Make arrow primary interchange for offline odfv execution
tokoko Apr 6, 2024
f3604d0
cleanup
tokoko Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
@tokoko
tokoko committed Apr 6, 2024
commit f3604d0baa7610d5000a9b0ffd7d5a1ec56a79fe
5 changes: 1 addition & 4 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,8 @@ def transform_arrow(
pa_table: pyarrow.Table,
full_feature_names: bool = False,
) -> pyarrow.Table:
# Apply on demand transformations
if not isinstance(pa_table, pyarrow.Table):
raise TypeError("get_transformed_features_df only accepts pyarrow.Table")
raise TypeError("transform_arrow only accepts pyarrow.Table")
columns_to_cleanup = []
for source_fv_projection in self.source_feature_view_projections.values():
for feature in source_fv_projection.features:
Expand All @@ -419,7 +418,6 @@ def transform_arrow(
)
columns_to_cleanup.append(full_feature_ref)

# Compute transformed values and apply to each result row
df_with_transformed_features: pyarrow.Table = (
self.feature_transformation.transform_arrow(pa_table)
)
Expand All @@ -435,7 +433,6 @@ def transform_arrow(
):
rename_columns[short_name] = long_name
elif not full_feature_names:
# Long name must be in dataframe.
rename_columns[long_name] = short_name

# Cleanup extra columns used for transformation
Expand Down