Skip to content

chore: Adding more tests for On Demand Feature Views #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 9 commits into from
Apr 4, 2024
Merged

chore: Adding more tests for On Demand Feature Views #4069

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
066880f
checking in progress...trying to fix tests
franciscojavierarceo Apr 3, 2024
79e6edc
testing more...
franciscojavierarceo Apr 3, 2024
262c586
fixed
franciscojavierarceo Apr 3, 2024
0ebfe7d
fixed some tests
franciscojavierarceo Apr 3, 2024
270f6c0
fixed test and serialization
franciscojavierarceo Apr 4, 2024
3574bcc
removed commented out code
franciscojavierarceo Apr 4, 2024
1d3745d
lint
franciscojavierarceo Apr 4, 2024
255ba05
added a test to make it explicit that feature calculation must happen…
franciscojavierarceo Apr 4, 2024
924ebd5
linter
franciscojavierarceo Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint 
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Apr 4, 2024
commit 1d3745d6f0d1833295187db15763685b70b8cb1c
16 changes: 8 additions & 8 deletions sdk/python/tests/unit/test_on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,14 @@ def test_python_native_transformation_mode():
)

assert (
on_demand_feature_view_python_native.feature_transformation
== PythonTransformation(python_native_udf, "python native udf source code")
on_demand_feature_view_python_native.feature_transformation
== PythonTransformation(python_native_udf, "python native udf source code")
)

with pytest.raises(TypeError):
assert (
on_demand_feature_view_python_native_err.feature_transformation
== PythonTransformation(python_native_udf, "python native udf source code")
on_demand_feature_view_python_native_err.feature_transformation
== PythonTransformation(python_native_udf, "python native udf source code")
)

with pytest.raises(TypeError):
Expand Down Expand Up @@ -241,8 +241,8 @@ def test_from_proto_backwards_compatible_udf():
# and to populate it in feature_transformation
proto = on_demand_feature_view.to_proto()
assert (
on_demand_feature_view.feature_transformation.udf_string
== proto.spec.feature_transformation.user_defined_function.body_text
on_demand_feature_view.feature_transformation.udf_string
== proto.spec.feature_transformation.user_defined_function.body_text
)
# Because of the current set of code this is just confirming it is empty
assert proto.spec.user_defined_function.body_text == ""
Expand All @@ -269,6 +269,6 @@ def test_from_proto_backwards_compatible_udf():
# And now we expect the to get the same object back under feature_transformation
reserialized_proto = OnDemandFeatureView.from_proto(proto)
assert (
reserialized_proto.feature_transformation.udf_string
== on_demand_feature_view.feature_transformation.udf_string
reserialized_proto.feature_transformation.udf_string
== on_demand_feature_view.feature_transformation.udf_string
)