Skip to content

feat: Lint with ruff #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 10 commits into from
Apr 3, 2024
Merged

feat: Lint with ruff #4043

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
af97594
feat: Lin with ruff
dmartinol Mar 26, 2024
26db7ca
fea: replace black with ruff format options
dmartinol Mar 26, 2024
8bd6ca6
fea: files reformatted due to ruff deviations from black
dmartinol Mar 26, 2024
7027d50
fix: restored mypy in lint-python target
dmartinol Mar 27, 2024
14525b0
fix: fixed formatting error
dmartinol Mar 27, 2024
a6c70b7
adding ruff format --check
dmartinol Mar 29, 2024
b622a08
Merge remote-tracking branch 'upstream/master' into ruff_linter
dmartinol Apr 2, 2024
b478cc2
Formatting updated files
dmartinol Apr 2, 2024
16c0a9b
Adding section separator
dmartinol Apr 2, 2024
9f4dd9a
rebased to main
dmartinol Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting updated files 
Signed-off-by: Daniele Martinoli <86618610+dmartinol@users.noreply.github.com>
  • Loading branch information
@dmartinol
dmartinol committed Apr 2, 2024
commit b478cc252640faa20e4515ede063c9b5cbb262da
10 changes: 5 additions & 5 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2011,11 +2011,11 @@ def _augment_response_with_on_demand_transforms(
if odfv.mode == "python":
if initial_response_dict is None:
initial_response_dict = initial_response.to_dict()
transformed_features_dict: Dict[
str, List[Any]
] = odfv.get_transformed_features(
initial_response_dict,
full_feature_names,
transformed_features_dict: Dict[str, List[Any]] = (
odfv.get_transformed_features(
initial_response_dict,
full_feature_names,
)
)
elif odfv.mode in {"pandas", "substrait"}:
if initial_response_df is None:
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_dataflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

import pyarrow as pa
import pyarrow.parquet as pq

from bytewax.dataflow import Dataflow # type: ignore
from bytewax.execution import cluster_main
from bytewax.inputs import ManualInputConfig
from bytewax.outputs import ManualOutputConfig

from feast import FeatureStore, FeatureView, RepoConfig
from feast.utils import _convert_arrow_to_proto, _run_pyarrow_field_mapping

Expand Down
2 changes: 0 additions & 2 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,6 @@ def get_transformed_features_dict(
self,
feature_dict: Dict[str, Any], # type: ignore
) -> Dict[str, Any]:

# we need a mapping from full feature name to short and back to do a renaming
# The simplest thing to do is to make the full reference, copy the columns with the short reference
# and rerun
Expand Down Expand Up @@ -667,7 +666,6 @@ def mainify(obj) -> None:
obj.__module__ = "__main__"

def decorator(user_function):

return_annotation = inspect.signature(user_function).return_annotation
if (
return_annotation
Expand Down
1 change: 0 additions & 1 deletion sdk/python/tests/integration/registration/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def minio_registry() -> Registry:
],
)
def test_apply_entity_integration(test_registry):

entity = Entity(
name="driver_car_id",
description="Car driver id",
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/infra/test_inference_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def view_with_missing_feature(features_df: pd.DataFrame) -> pd.DataFrame:
mode="pandas",
)
def python_native_test_invalid_pandas_view(
input_dict: Dict[str, Any]
input_dict: Dict[str, Any],
) -> Dict[str, Any]:
output_dict: Dict[str, Any] = {
"output": input_dict["some_date"],
Expand Down